Dashboard: Fix template insertion #12346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
commented
Sep 21, 2022
| @@ -127,11 +127,23 @@ protected function prepare_item_for_database( $request ) { | |||
| if ( ! empty( $schema['properties']['content'] ) ) { | |||
|
|
|||
| // Ensure that content and story_data are updated together. | |||
There was a problem hiding this comment.
Considering just removing this whole bit. Not sure if this has ever been useful.
There was a problem hiding this comment.
Do you mean the check + throwing the error if not updated together to allow updating separately?
|
Plugin builds for 0d19e15 are ready 🛎️!
|
|
Size Change: -15.8 kB (-1%) Total Size: 2.71 MB
ℹ️ View Unchanged
|
miina
reviewed
Sep 21, 2022
| @@ -127,11 +127,23 @@ protected function prepare_item_for_database( $request ) { | |||
| if ( ! empty( $schema['properties']['content'] ) ) { | |||
|
|
|||
| // Ensure that content and story_data are updated together. | |||
There was a problem hiding this comment.
Do you mean the check + throwing the error if not updated together to allow updating separately?
timarney
approved these changes
Sep 22, 2022
spacedmonkey
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#12237 accidentally broke the "Use template" functionality on the dashboard as it turns out the element types were in fact used after all. It wasn't caught because of a missing (disabled) e2e test.
But now no more!
Summary
Instead of just reverting #12237, this PR removes usage of the
outputpackage from the dashboard to fix the template insertion functionality.Relevant Technical Choices
Fixes and re-enables the relevant e2e test.
To-do
User-facing changes
No visual changes, just a fixed user flow
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #12345
Fixes #12024