Date Picker: show timezone abbreviation if possible #12353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 8d1f35e are ready 🛎️!
|
|
Size Change: +29 B (0%) Total Size: 2.71 MB ℹ️ View Unchanged
|
This comment was marked as duplicate.
This comment was marked as duplicate.
swissspidy
reviewed
Sep 21, 2022
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
swissspidy
added
the
Type: Enhancement
|
If you set the time zone to christmas, then you get some weird styling issues. See gutenberg.
Any thoughts on this @swissspidy ? |
|
You mean this?
That clearly looks wrong :-) Can we fix that? |
|
Perhaps easiest to write some Jest tests with a data provider so we can discuss expected behavior for a case like this. |
I don't know what is the expected behavior. What do you expect to happen here? |
|
The output in the Gutenberg calendar looks more reasonable.
|
|
@swissspidy The logic is now exactly the same as gutenberg. In my testing it seems to work well and is inline with what users would expect, if they have used the gutenberg date picker. |
swissspidy
approved these changes
Sep 28, 2022
swissspidy
added
Group: Document Panel
Group: Workspace
|
@spacedmonkey - i found one place where the new time zone information is only partially visible: within the Publish / Story Details popup that you get when user first publishes the story: Is this something that we should fix ? |
|
Verified via stories-qa test story:
Here are a few of the timezones that I tried: |
The tooltip is not newly added in this PR. We can deal with this in #1391 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Have a more human readable time zone in date picker.
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #12234