Block: Remove minimum width from grid items #12469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plugin builds for 5a1b4b0 are ready 🛎️!
|
|
Size Change: -77 B (0%) Total Size: 2.72 MB ℹ️ View Unchanged
|
|
Does this affect anything on the frontend? Could you add QA instructions? |
|
@swissspidy Not adding QA instructions is by design. Want to get thoughts on the PR first. In my limited testing, I can't see any effect. QA might be better than me to look. As I don't write the block, it is hard to know why this min width value was required in the first place. I am also not sure if this what the workaround / fix we would want. It may result in different styling than desired. |
|
I'll check it out, but instructions are helpful for code reviewers too. |
Not sure what instructions I can give. The video shows the new behaviour. It is more about setting it to 4 columns and testing the responsive. |
swissspidy
changed the title
swissspidy
approved these changes
Oct 24, 2022
swissspidy
added
Type: Bug
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
Remove min width of story and let flex box do it's own things.
Relevant Technical Choices
Removing min width might mean stories look diffferent or other styling issues.
To-do
User-facing changes
Screen.Recording.2022-10-13.at.18.03.53.mov
Testing Instructions
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
Does this PR change what data or activity we track or use?
Does this PR have a legal-related impact?
Checklist
Type: XYZlabel to the PRFixes #11960