Block: Fix carousel width & whitespace issues #12564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Bug
|
Plugin builds for 484ea39 are ready 🛎️!
|
|
Size Change: +57 B (0%) Total Size: 2.72 MB ℹ️ View Unchanged
|
|
So this is a revert of - #12469? What about this issue? How about lowering the min width? Would this help the issue? |
|
Maybe just add min width of in carousel is set. |
|
@spacedmonkey This is not a full revert. This only adds back the min-width for carousels, but not for the grid column layout (which the original PR was targeting) |
spacedmonkey
approved these changes
Oct 31, 2022
8 tasks
swissspidy
changed the title
|
Confirmed the issue in And the fix in |
|
Further test conducted:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR fixes two issues:
First, the Glider track width calculation was quite off, causing white space to appear at the beginning of the carousel. Noticeable mostly on Firefox, but also on Chrome.
Summary
Fixes a regression with the carousel layout in v1.26.0.
Also avoids unnecessary whitespace at the beginning of the carousel
Relevant Technical Choices
To-do
User-facing changes
Whitespace issue
See: https://www.youtube.com/watch?v=dCpdV3PurC0
Width issue
Before:
After:
Testing Instructions
This PR can be tested by following these steps:
For completeness sake, also test other layout options to see if there are no regressions.
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #12563
Fixes #12170