Do not unnecessarily fetch stories/taxonomies #12653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Enhancement
|
Size Change: +37 B (0%) Total Size: 2.71 MB ℹ️ View Unchanged
|
|
Plugin builds for 560a65c are ready 🛎️!
|
|
Any suggestions regarding the failing karma tests are welcome |
|
@swissspidy I wanted to test the PR to see if the Karma tests failures might be valid but can't open the Explore templates at all currently, crashes with the following error:
Is this something you've also seen, or works ok for you? |
|
Haven‘t seen it yet, sounds like a bug I introduced 🙃 |
|
Also seeing this error. |
|
Seeing the "find" issue as well when trying to visit explore templates Adding filters?.find to get the page to load I can see
filters is undefined |
* Add z-index to icons * Add z-indexes.
* Moved types around and converted elements package * WIP: convert element-library package * Re-moved types to relevant packages and untyped the element-library * Updating package.json * Feedback improvements * Fixed more from PR feedback * Fix lint error * Moved element definitions to element library package and updated dependencies * Fixed React-17 React.FC issue and resource id reference * Removed Page.type property as it is redundant Also fixed a test. Note that there are many more instance of type:"page" in the code, but most are related to tests that will probably still work fine or templates, which will also work fine with an extra unused property. Should we add a migration though? * Fix imports of background audio prop type * Fixed a karma test * Finally fixed that annoying bg-shape-element copy thingy * Added a comment to make sense of it * Fix eyedropper * Target correct element * Updated type references for config providers * Missing types in package.json? * Reorganized data types to elements package Co-authored-by: Marcin Pietruszka <marcin@webskill.pl>
Co-authored-by: Jonny Harris <jon@spacedmonkey.co.uk>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This reverts commit dea994a.
Co-authored-by: Pascal Birchler <pascalb@google.com>
|
Is this ready for review again? |
|
Yeah now it is. |
|
Outside of I see e2e tests failing on 5.9 (Telemetry Banner › should not display the banner after it has been closed) --- testing locally looks good. |
spacedmonkey
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When testing #12626 but also otherwise, I noticed superfluous HTTP requests for fetching stories and taxonomies when not even visiting the dashboard itself.
Summary
Do not unnecessarily fetch stories/taxonomies when directly visiting a sub page like the settings page.
Relevant Technical Choices
To-do
User-facing changes
N/A
Testing Instructions
This PR can be tested by following these steps:
/wp-admin/edit.php?post_type=web-story&page=stories-dashboard#/editor-settingsdirectlyReviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZlabel to the PRFixes #