Update react-moveable and disable snap distance #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5.49 kB (1%) Total Size: 351 kB
ℹ️ View Unchanged
|
swissspidy
reviewed
Mar 5, 2020
swissspidy
reviewed
Mar 5, 2020
swissspidy
added
the
Type: Enhancement
swissspidy
approved these changes
Mar 5, 2020
dvoytenko
suggested changes
Mar 5, 2020
…-wp into update/react-moveable
miina
reviewed
Mar 6, 2020
| @@ -29,6 +29,7 @@ import objectWithout from '../../utils/objectWithout'; | |||
| import { useTransform } from '../transform'; | |||
| import { useUnits } from '../../units'; | |||
| import { getDefinitionForType } from '../../elements'; | |||
| import { useGlobalKeyDownEffect, useGlobalKeyUpEffect } from '../keyboard'; | |||
There was a problem hiding this comment.
Since single- and multiselection seem to share the snapping props, would it perhaps make sense to create the key handler in Selection and set the snapping props there instead to pass down? Or alternatively use an util for getting the snapping props. Thoughts?
There was a problem hiding this comment.
I think there's a lot more we can refactor between the two, I'd leave this for another PR
dvoytenko
suggested changes
Mar 6, 2020
dvoytenko
approved these changes
Mar 9, 2020
wassgha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #285, Closes #370
Changes
react-moveableto0.18.1keyup,keypressorkeydowninuseKeyDownEffect