Update react-moveable and disable snap digits again #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +63 B (0%) Total Size: 510 kB
ℹ️ View Unchanged
|
dvoytenko
approved these changes
Apr 1, 2020
barklund
reviewed
Apr 1, 2020
| @@ -273,7 +273,7 @@ function MultiSelectionMovable({ selectedElements }) { | |||
| verticalGuidelines={canSnap ? [0, canvasWidth / 2, canvasWidth] : []} | |||
| elementGuidelines={otherNodes} | |||
| snapGap={canSnap} | |||
| isDisplaySnapDigit={true} | |||
| isDisplaySnapDigit={false} | |||
There was a problem hiding this comment.
What was this doing, that is now not necessary?
There was a problem hiding this comment.
It prints actual distances, which was pretty nice. Unfortunately, at lower resolutions (when our canvas is resized responsively) these numbers are scaled and not in our "data pixels". So it's better to disable for now. Hopefully eventually we can specify our "formatter" callback where we could reconcile this.
There was a problem hiding this comment.
Moveable had a bug that still showed numbers when passing false
#884 temporarily turned numbers on again.
Now the bug seems to be fixed.
See daybrush/moveable#200 for background
obetomuniz
added a commit
that referenced
this pull request
Apr 1, 2020
…working * master: (50 commits) Update react-moveable and disable snap digits again (#941) Template Animation: Added move and repeater animation (#618) (#881) Fix storybook hierarchy (#939) Fix spinner / progress bar when saving (#937) Change placeholder text for pre-publish panel (#934) Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931) Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932) Fix Document panel crashing (#930) Fix deployment (#928) Update URL when publishing post. (#836) Fix multiple warnings and proptype issues (#929) Added scroll behavior to layer panel when reordering by mouse (#551) Fix forms events in Firefox (#875) Add save story error message (#888) lints fixed tests font size calculations fixed Use native aspect-ration format for grid layers Fixed behavior for selected elements (#924) Fix ID prefix in auto-advanve-after (#915) ...
obetomuniz
added a commit
that referenced
this pull request
Apr 1, 2020
* master: (56 commits) Add Snackbar for Invalid Links. (#912) Renamed files to make more sense, updated aria-label. Finished initial pass on Dashboard My Stories Page UI Grid View Update react-moveable and disable snap digits again (#941) Template Animation: Added move and repeater animation (#618) (#881) Fix storybook hierarchy (#939) Fix spinner / progress bar when saving (#937) Change placeholder text for pre-publish panel (#934) Bump @ampproject/toolbox-optimizer from 2.0.1 to 2.1.0 (#931) Bump eslint-plugin-testing-library from 3.0.1 to 3.0.2 (#932) Fix Document panel crashing (#930) Fix deployment (#928) Update URL when publishing post. (#836) Fix multiple warnings and proptype issues (#929) Added scroll behavior to layer panel when reordering by mouse (#551) Fix forms events in Firefox (#875) Add save story error message (#888) lints fixed tests font size calculations fixed ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #936