Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snap to common element distances #200

Closed
wassgha opened this issue Mar 20, 2020 · 6 comments
Closed

Snap to common element distances #200

wassgha opened this issue Mar 20, 2020 · 6 comments
Labels
bug Something isn't working complete Feature
Milestone
0.16.2

Comments

@wassgha
Copy link

wassgha commented Mar 20, 2020

Would be great if this could support snapping the common distance between existing elements. There are a few cases:

Base case (horizontal):
ezgif com-crop (1)

Vertical:
ezgif com-video-to-gif (28)

Rotated:
ezgif com-video-to-gif (29)

Multiple:
ezgif com-video-to-gif (30)
@daybrush
Copy link
Owner

@wassgha

Thank you :) I'll try it for next release.

@daybrush
Copy link
Owner

@wassgha

Maybe it feels like this.

무제

@daybrush daybrush added this to the 0.16.0 milestone Mar 25, 2020
daybrush added a commit that referenced this issue Mar 27, 2020
@daybrush
feat: add gapSnap props #200
4cecb27
@wassgha
Copy link
Author

wassgha commented Mar 30, 2020

Looks awesome! Thank you :)

@wassgha wassgha mentioned this issue Mar 30, 2020
Closed
@daybrush
Copy link
Owner

daybrush commented Mar 30, 2020 •
edited

@wassgha

  • moveable 0.16.1
  • react-moveable 0.19.0
  • preact-moveable 0.18.0
  • ngx-moveable 0.12.0
  • svelte-moveable 0.7.0

moveable's new version is released. Check it again. Thank you :)

use snapGap props. (default: true)

@wassgha
Copy link
Author

wassgha commented Mar 30, 2020

Works great! Awesome work! 🎉 One little thing, when isDisplaySnapDigit={false} the number is displayed but set to 0. Would be great if the number was completely hidden. Bonus points if this is controlled by a different boolean (e.g. isGapSnapDigitVisible). Thank you!

@daybrush daybrush modified the milestones: 0.16.0, 0.16.1 Apr 1, 2020
daybrush added a commit that referenced this issue Apr 1, 2020
@daybrush
fix: apply isDisplaySnapDigit to gap guidelines #200
86b8edb
@daybrush daybrush added the bug Something isn't working label Apr 1, 2020
@daybrush
Copy link
Owner

daybrush commented Apr 1, 2020

@wassgha

react-moveable 0.19.1 is released.

Check it again.

@swissspidy swissspidy mentioned this issue Apr 1, 2020
Merged
@alexconstantin alexconstantin mentioned this issue Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working complete Feature
Projects
None yet
Milestone
0.16.2
Development

No branches or pull requests
2 participants
@wassgha @daybrush