Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep reference not set & previous value used #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DeanMarkTaylor
Copy link

Setting a value via this.set('parent.value') would fail to set.
In addition the value didn't seem to be set, debugging in step though the old value was being used instead of the new value.

Setting a value via `this.set('parent.value`)` would fail to set.
In addition the value didn't seem to be set, debugging in step though the old value was being used instead of the new value.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@DeanMarkTaylor
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@ebidel
Copy link
Contributor

ebidel commented Jan 20, 2016

Can you add a test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants