Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #14

Merged
merged 2 commits into from
Jun 3, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/_services/auth.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ import { HttpClient, HttpHeaders } from '@angular/common/http';
import { Observable } from 'rxjs/Observable';
import 'rxjs/add/operator/map';

import { User } from '../_models/user';
import { AppUrl } from '../_config/url.config';
import { Owner } from '../_models/owner';

@Injectable()
export class AuthService{
Expand All @@ -27,7 +25,7 @@ export class AuthService{

let body = { email: email, password: password };

return this.http.post<User>( url, body, this.httpOptions)
return this.http.post<any>( url, body, this.httpOptions)
.map( user => {
let token = user && user.token;
if (token) {
Expand Down
34 changes: 20 additions & 14 deletions src/pages/signin/signin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@ export class SignInPage {
email: string = "";
password: string = "";

loading = this.loadingController.create({
content: 'Por favor, aguarde...',
spinner: 'bubbles'
});

constructor(
public navCtrl: NavController,
public auth: AuthService,
Expand All @@ -32,22 +27,22 @@ export class SignInPage {

async signIn(){

this.loading.present();
let loading = this.loading();

if(this.type === 'user'){
await this.userSignIn();
await this.userSignIn(loading);
}

if(this.type === 'owner'){
await this.ownerSignIn();
await this.ownerSignIn(loading);
}

}

userSignIn(){
userSignIn(loading){
this.auth.userSignIn(this.email, this.password).subscribe(
user => {
this.loading.dismiss();
loading.dismiss();
if(user){
this.resetFields();
this.navCtrl.push(HomePage, {}, {animate: false});
Expand All @@ -56,16 +51,16 @@ export class SignInPage {
}
},
err => {
this.loading.dismiss();
loading.dismiss();
this.presentAlert("Usuário ou senha incorretos!");
}
)
}

ownerSignIn(){
ownerSignIn(loading){
this.auth.ownerSignIn(this.email, this.password).subscribe(
user => {
this.loading.dismiss();
loading.dismiss();
if(user){
this.resetFields();
this.navCtrl.push(OwnerHomePage, {}, {animate: false});
Expand All @@ -74,7 +69,7 @@ export class SignInPage {
}
},
err => {
this.loading.dismiss();
loading.dismiss();
this.presentAlert("Usuário ou senha incorretos!");
}
)
Expand All @@ -94,6 +89,17 @@ export class SignInPage {
this.password = "";
}

loading(){
let loading = this.loadingController.create({
content: 'Por favor, aguarde...',
spinner: 'bubbles'
});

loading.present();

return loading;
}

goSignUp(){
this.navCtrl.push(SignUpPage, {}, {animate: false});
}
Expand Down
36 changes: 21 additions & 15 deletions src/pages/signup/signup.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Component } from '@angular/core';
import { NavController, AlertController, LoadingController, ModalController} from 'ionic-angular';
import { NavController, AlertController, LoadingController} from 'ionic-angular';
import { SignInPage } from '../signin/signin';

import { User } from '../../_models/user';
Expand All @@ -20,11 +20,6 @@ export class SignUpPage {
password: string = "";
password_confirm: string = "";

loading = this.loadingController.create({
content: 'Por favor, aguarde...',
spinner: 'bubbles'
});

constructor(
public navCtrl: NavController,
public alert:AlertController,
Expand Down Expand Up @@ -65,48 +60,48 @@ export class SignUpPage {
async createUser(){
if(this.validateFields()){

this.loading.present();
let loading = this.loading();

if(this.type === 'user'){
await this.createNormalUser();
await this.createNormalUser(loading);
}

if (this.type === 'owner'){
await this.createOwner();
await this.createOwner(loading);
}
}
}

async createNormalUser(){
async createNormalUser(loading){
let user = new User(this.username, this.email, this.password);

await this.usersService.create(user).subscribe(
data => {
this.loading.dismiss();
loading.dismiss();
this.createdUserAlert("Usuário criado com sucesso!");
this.clearFields();
this.goSignIn();
},
err => {
this.loading.dismiss();
loading.dismiss();
this.presentAlert(err.error.message);
}
)
}

async createOwner(){
async createOwner(loading){

let owner = new Owner(this.email, this.password);

await this.ownerService.create(owner).subscribe(
data => {
this.loading.dismiss();
loading.dismiss();
this.createdUserAlert("Empresário criado com sucesso!");
this.clearFields();
this.goSignIn();
},
err => {
this.loading.dismiss();
loading.dismiss();
this.presentAlert("Empresário não pode ser criado!");
}
)
Expand Down Expand Up @@ -137,6 +132,17 @@ export class SignUpPage {
alert.present();
}

loading(){
let loading = this.loadingController.create({
content: 'Por favor, aguarde...',
spinner: 'bubbles'
});

loading.present();

return loading;
}

goSignIn(){
this.navCtrl.push(SignInPage, {}, {animate: false});
}
Expand Down