Incorporate import_expression logic into jishaku. #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify logic from Sachaa-Thanasius/experimental. - Copy modified tests. - Substitute import_expression.parse with inline_import.parse. - Remove IMPORTER.
- Fix test break, since `tokenize.tokenize` has buggy behavior that wasn't backported. - See python/cpython#79288 and python/cpython#88833. - Adjust typing using so everything from typing is prepended with `typing.`.
|
Regarding the remaining points:
|
|
On a tangential note: it was mentioned in the related issue that the inline import feature should pass "the litmus test" on 3.8-3.12, but in the overall tracking issue for the next release (#212), it was also mentioned that jishaku would get a bump to 3.10. Is the latter still true, and if so, do I only have to care about this being compatible with 3.10+? |
- `typing_extensions` is a direct dependency, so using it directly is fine. - `copy_annotations()` was using functools.wraps with the wrong function as the wrapper.
|
Since ioistired is back, I'll close this PR once upstream has been fixed. |
ioistired
added a commit
to ioistired/jishaku
that referenced
this pull request
May 27, 2024
Closes Gorialis#231 Closes Gorialis#228
ioistired
added a commit
to ioistired/jishaku
that referenced
this pull request
May 27, 2024
Closes Gorialis#231 Closes Gorialis#228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
import_expressionis effectively unmaintained and isn't functional on python3.12 (according the issue linked below). The new logic should be functional on 3.8+.Closes #228.
Summary of changes made
Adds a token stream transformer and AST transformer and incorporates them into a parse function with the same signature as
ast.parseto achieve a similar end result toimport_expression.parse. Also added tests, mostly sourced fromimport_expressionand modified to account for the different and much smaller API surface.Checklist