Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the plugin for grafana 7.1.x #112

Closed
wants to merge 1 commit into from

Conversation

craigching
Copy link

This fixes the plugin for Grafana 7.1.x. The return from ds.query() is an Observable, which can be converted to a promise with toPromise()

@craigching
Copy link
Author

The one thing I'm not certain about his how backwards compatible this is. I am pretty sure the Observable change went in quite awhile ago, but this may need some love to support older versions of Grafana.

@Gauravshah
Copy link
Member

Thanks @craigching for your contribution.
do you know which release added support for Observable ? I am unable to find it. That way we can update readme to state minimum grafana requirements

@Gauravshah
Copy link
Member

fixes #104

@Gauravshah
Copy link
Member

it was atleast added to mixed source in 6.4 grafana/grafana#19037

@Gauravshah
Copy link
Member

@ShilpaSivanesan can you review and check basic compatibility ?

@craigching
Copy link
Author

it was atleast added to mixed source in 6.4 grafana/grafana#19037

Yes, exactly. Thanks for taking the time to incorporate my PR! Let me know if you want any changes.

@craigching
Copy link
Author

Any updates on getting this merged? I'd love to help in any way I can.

@Gauravshah
Copy link
Member

team is stuck with internal projects, Will request @ShilpaSivanesan to have a look at it next week. Apologies for the delay

@zebardy
Copy link

zebardy commented Nov 20, 2020

Is there any update regarding this fix. Really keen for this as the plugin is currently unusable for us at the moment. Appreciate all of the work in producing and maintaining this plugin, and understand the pressure of competing priorities. Just keen for an update.

@ichiong
Copy link

ichiong commented Nov 20, 2020

Any updates on this? We are also in need of this plugin to be fixed for later versions of grafana so we can continue monitoring our systems... Thanks so much.

@ZyanKLee
Copy link

When installing the plugin with this patch within the Grafana v7.3.6 (ea06633c34) docker image there is an error message "ds.query(...).toPromise is not a function"

Bildschirmfoto 2020-12-21 um 11 28 52

@Gauravshah
Copy link
Member

seems to be compatibility issue with 7.3 vs 7.2 and previous versions. Looking into fixing further

@ShilpaSivanesan
Copy link
Contributor

Thanks, @craigching for your contribution.
We had a compatibility issue with 7.3 vs 7.2. Have added the fix on top of your commits.
fix #118 works on all 7.x versions also tested on 6.5.2 and 6.7.5

@barbudor
Copy link

Hi
Is v0.0.4 going to be available from Grafana plugin repository ?
Thanks

@Gauravshah
Copy link
Member

waiting on approval from grafana grafana/grafana-plugin-repository#827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants