Bug: Uninitialized data.

- Fixed bug where the isIPv4Address() port value could be left uninitialized.
GothenburgBitFactory · Apr 27, 2019 · f48f0bf · f48f0bf
1 parent 7c91709
commit f48f0bf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/ChangeLog b/ChangeLog
@@ -1,5 +1,6 @@
 master/HEAD
 
+- Fixed bug where the isIPv4Address() port value could be left uninitialized.
 - Removed CMake CMP0037.
 - TI-91 Timewarrior does not compile on DragonFly
           (thanks to Michael Neumann)

diff --git a/src/ip.cpp b/src/ip.cpp
@@ -97,7 +97,6 @@ static bool isIPv4BlockSet (const std::string& input, unsigned int& c)
       isChar      (input, '.', c) &&
       isIPv4Block (input,      c))
   {
-
     return true;
   }
 
@@ -190,6 +189,7 @@ bool isIPv4Address (const std::string& input, std::string& address, int& port)
     if (isEOS (input, c))
     {
       address = input.substr (0, std::min (c, colon));
+      port = 0;
       if (! isEOS (input, colon))
         port = std::stoi (input.substr (colon + 1));