Skip to content

Commit

Permalink
fix(buffer): make exception constructors public
Browse files Browse the repository at this point in the history
  • Loading branch information
lmichaelis committed Apr 3, 2023
1 parent 1d6a3b7 commit 19ab9ac
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions include/phoenix/buffer.hh
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ namespace phoenix {
/// is more than the number of bytes remaining.
class buffer_underflow : public buffer_error {
public:
PHOENIX_INTERNAL buffer_underflow(std::uint64_t byte, std::uint64_t size);
PHOENIX_INTERNAL buffer_underflow(std::uint64_t byte, std::uint64_t size, std::string&& context);
PHOENIX_INTERNAL buffer_underflow(std::uint64_t byte, std::string&& context);
PHOENIX_API buffer_underflow(std::uint64_t byte, std::uint64_t size);
PHOENIX_API buffer_underflow(std::uint64_t byte, std::uint64_t size, std::string&& context);
PHOENIX_API buffer_underflow(std::uint64_t byte, std::string&& context);

public:
const std::uint64_t byte, size;
Expand All @@ -47,8 +47,8 @@ namespace phoenix {
/// is more than the number of bytes remaining.
class buffer_overflow : public buffer_error {
public:
PHOENIX_INTERNAL buffer_overflow(std::uint64_t byte, std::uint64_t size);
PHOENIX_INTERNAL buffer_overflow(std::uint64_t byte, std::uint64_t size, std::string&& context);
PHOENIX_API buffer_overflow(std::uint64_t byte, std::uint64_t size);
PHOENIX_API buffer_overflow(std::uint64_t byte, std::uint64_t size, std::string&& context);

public:
const std::uint64_t byte, size;
Expand All @@ -58,7 +58,7 @@ namespace phoenix {
/// \brief Exception thrown if a write is attempted on a readonly buffer.
class buffer_readonly : public buffer_error {
public:
PHOENIX_INTERNAL explicit buffer_readonly() : buffer_error("buffer is not readonly") {}
PHOENIX_API explicit buffer_readonly() : buffer_error("buffer is not readonly") {}
};

/// \brief Base class for all buffer backings.
Expand Down

0 comments on commit 19ab9ac

Please sign in to comment.