Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Replace bottom padding on checkbox and radio item with calculated bottom margin. #1966

Closed
bdfranck opened this issue Jun 26, 2024 · 0 comments · Fixed by #1967
Assignees
Labels
Enhancement New feature or request ready-for-contribution Use to mark any story that is contributor friendly

Comments

@bdfranck
Copy link
Collaborator

bdfranck commented Jun 26, 2024

Is your feature request related to a problem? Please describe

In my previous PR for the checkbox component (#1869), I used bottom padding to match the radio item.

padding-bottom: var(--goa-space-m);

But I've since noticed a much better approach used by other components: set a default calculated margin.

export let mb: Spacing = "m";

This approach gives teams more flexibility to adjust or remove the bottom margin as needed. They can set the mb property instead of relying on negative margins.

Describe the solution you'd like

  1. Add calculated margins to the radio item component
  2. Replace the bottom padding from the checkbox and radio item with a calculated bottom margin: export let mb: Spacing = "m";

Are you able to assist to bring the feature to reality?

Of course! I've created an initial PR for the idea: #1967

@bdfranck bdfranck added the Enhancement New feature or request label Jun 26, 2024
bdfranck added a commit to bdfranck/ui-components that referenced this issue Jun 26, 2024
bdfranck added a commit to bdfranck/ui-components that referenced this issue Jun 26, 2024
@Spark450 Spark450 added the ready-for-contribution Use to mark any story that is contributor friendly label Jul 4, 2024
@ArakTaiRoth ArakTaiRoth linked a pull request Jul 11, 2024 that will close this issue
bdfranck added a commit to bdfranck/ui-components that referenced this issue Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request ready-for-contribution Use to mark any story that is contributor friendly
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants