Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating the GovReady Dashboard with GovReady Q #200

Closed
wants to merge 0 commits into from

Conversation

jlyon
Copy link
Contributor

@jlyon jlyon commented Nov 3, 2016

This Pull Request adds the GovReady Dashboard to Q. A new tab, similar to Settings was added in project.html.

The hashbang logic for the Bootstrap tabs, around line 410 was conflicting with hashbang logic in the React app, so it has been disabled. It did not appear to be working properly (it would add the #tab=settings hashbang, but refreshing the page would leave you on the first tab). An issue has been created in the GovReady Dashboard project: proudcity/GovReady-Agent-Client#4.

@JoshData
Copy link
Contributor

JoshData commented Nov 3, 2016

We should find a place for this to live in an area that's not as generic as project.html.

@gregelin gregelin changed the title Integrating the GobReeady Dashboard with GovReady Q Integrating the GobReady Dashboard with GovReady Q Nov 3, 2016
@gregelin
Copy link
Contributor

gregelin commented Nov 3, 2016

@JoshData

  • Do you have thoughts of what would be a better location?
  • I think it would be easier if @jlyon added the feature to project.html and then @JoshData figured out an alternative page. Would that work for you Josh?

@jlyon
Copy link
Contributor Author

jlyon commented Nov 3, 2016

Note: After you login to Auth0, the page is refreshed. We need to set the tab as the Dashboard. There is some code around line 345 that does this with a 'dashboardLoginRedirect' JS cookie:

        // After you login, we reload the page, so we want to set the active tab as Dashboard.
        if (getCookie('dashboardLoginRedirect')) {
          setTimeout(function(){ 
            $('#project-dashboard-tab>a').trigger('click'); 
          }, 1000);

          setCookie('dashboardLoginRedirect', false, 0);
        }

@JoshData
Copy link
Contributor

JoshData commented Nov 4, 2016

Hey.

I'm working on putting this in the https://github.com/GovReady/govready-q-ssp-module repo.

I'm getting:

XMLHttpRequest cannot load https://govready.auth0.com/user/ssodata. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://somethinghere.localhost:8000' is therefore not allowed access.

Do we need to do something special to permit debugging on localhost?

@jlyon
Copy link
Contributor Author

jlyon commented Nov 4, 2016

Hey,

Yes, for some reason, wildcards don't work for localhost domains in the Auth0 CORS settings. I just added http://somethinghere.localhost:8000 and http://test.localhost:8000.

Thanks,
Jeff

@JoshData JoshData changed the title Integrating the GobReady Dashboard with GovReady Q Integrating the GovReady Dashboard with GovReady Q Nov 4, 2016
@JoshData
Copy link
Contributor

JoshData commented Nov 4, 2016

Thanks. Greg gave me the test credentials (at GovReady/GovReady-Agent-Client#1) but when I log in (which seems to work), I get

Looks like something didn't load properly

@JoshData JoshData force-pushed the master branch 5 times, most recently from 7184455 to baf233b Compare November 7, 2016 22:52
@jlyon
Copy link
Contributor Author

jlyon commented Nov 10, 2016

@JoshData sorry for the delayed response. We've been working on refactoring the Dashboard code. We finished yesterday. This error should be replaced with a screen prompting you to create a new site:
screenshot from 2016-11-10 13 11 48

Once you push the code to https://q.govready.com/, I might need to mess with the CORS settings in Auth0. Could you pass along information for a test account that would have access to the dashboard and I can take it from there (my email is jeff@albatrossdigital.com). Thanks!

@JoshData
Copy link
Contributor

Great. I've pushed the code and you should have an email invitation from Q to join a project to test the dashboard. You should see the dashboard tab once you get all the way in.

Your HTML lives at https://github.com/GovReady/govready-q-ssp-module/blob/master/modules/project.yaml#L116.

I didn't commit the change to the window location fragment issue that affected tabs. We need to find a way around that (if you haven't already).

@jlyon
Copy link
Contributor Author

jlyon commented Nov 11, 2016

Thanks @JoshData. I was able to login and test everything out. We'll look into a fix for the tab hashbang conflict today. I might create another PR.

@jlyon jlyon closed this Nov 13, 2016
gregelin added a commit that referenced this pull request Jun 25, 2022
feat(Permissions): Support private components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants