-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating the GovReady Dashboard with GovReady Q #200
Conversation
We should find a place for this to live in an area that's not as generic as project.html. |
Note: After you login to Auth0, the page is refreshed. We need to set the tab as the Dashboard. There is some code around line 345 that does this with a 'dashboardLoginRedirect' JS cookie:
|
Hey. I'm working on putting this in the https://github.com/GovReady/govready-q-ssp-module repo. I'm getting:
Do we need to do something special to permit debugging on localhost? |
Hey, Yes, for some reason, wildcards don't work for localhost domains in the Auth0 CORS settings. I just added http://somethinghere.localhost:8000 and http://test.localhost:8000. Thanks, |
Thanks. Greg gave me the test credentials (at GovReady/GovReady-Agent-Client#1) but when I log in (which seems to work), I get
|
7184455
to
baf233b
Compare
@JoshData sorry for the delayed response. We've been working on refactoring the Dashboard code. We finished yesterday. This error should be replaced with a screen prompting you to create a new site: Once you push the code to https://q.govready.com/, I might need to mess with the CORS settings in Auth0. Could you pass along information for a test account that would have access to the dashboard and I can take it from there (my email is jeff@albatrossdigital.com). Thanks! |
Great. I've pushed the code and you should have an email invitation from Q to join a project to test the dashboard. You should see the dashboard tab once you get all the way in. Your HTML lives at https://github.com/GovReady/govready-q-ssp-module/blob/master/modules/project.yaml#L116. I didn't commit the change to the window location fragment issue that affected tabs. We need to find a way around that (if you haven't already). |
Thanks @JoshData. I was able to login and test everything out. We'll look into a fix for the tab hashbang conflict today. I might create another PR. |
feat(Permissions): Support private components
This Pull Request adds the GovReady Dashboard to Q. A new tab, similar to Settings was added in project.html.
The hashbang logic for the Bootstrap tabs, around line 410 was conflicting with hashbang logic in the React app, so it has been disabled. It did not appear to be working properly (it would add the #tab=settings hashbang, but refreshing the page would leave you on the first tab). An issue has been created in the GovReady Dashboard project: proudcity/GovReady-Agent-Client#4.