Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish and documentation #1

Merged
merged 3 commits into from
Jan 22, 2019
Merged

Polish and documentation #1

merged 3 commits into from
Jan 22, 2019

Conversation

dopeboy
Copy link

@dopeboy dopeboy commented Jan 22, 2019

Bug fixes:

  • Typing in a lat/lng combination like '12, 34' resulted in the whitespace preceding '34' being picked up. This has been fixed.

Polish:

  • To improve the UX when onboarding, I've swapped the locations of the 'API Key' and 'Location' fields. I think it is misleading to be presented the 'Location' field first because installation/setup should precede configuration. Creating an API key is part of the installation of the applet and the user should complete that before moving on to configuration (location, etc).
  • The copy on some of the tooltips and buttons have been tightened up.

Documentation:

  • I've added a simple guide to create an API key and set a location.

Outstanding bugs I didn't look at:

  • I'm seeing intermittent flickering on my tray. It'll stay steady for awhile and then flicker between the weather and "Service not available" a couple times. It's doing this every 30 seconds or so.

@dopeboy dopeboy mentioned this pull request Jan 22, 2019
Merged
@Gr3q
Copy link
Owner

Gr3q commented Jan 22, 2019

Thank You, for the contribution,

I've fixed the flickering on my local, I'll push that later today

@Gr3q Gr3q merged commit 037c253 into Gr3q:master Jan 22, 2019
Gr3q pushed a commit that referenced this pull request Sep 29, 2019
@claudiux @brownsr
[SpicesUpdate@claudiux] v4.0.0: Make sure to download the latest vers…
fada235 
…ion of Spices. (Cinnamon 3.8 and following.) (linuxmint#2577)

* v4.0.0: Make sure to download thelatest version of Spices. (Cinnamon 3.8 and following.)

* Removing useless files

* Removing useless files #2

* Removing useless files #3

* cs 4.2 Appeases Codacy #1

* cs 4.2 Appeases Codacy #2

* cs 4.2 Appeases Codacy #3

* cs 4.0 Appeases Codacy #1

* cs 3.8 Appeases Codacy #1

* cs 4.0 Appeases Codacy #2

* cs 4.0 Appeases Codacy #3

* cs 4.0 Appeases Codacy #4

* cs 3.8 Code cleanup

* cs 3.8 Appeases Codacy #2

* cs 3.8 Appeases Codacy #3

* cs 4.0 Appeases Codacy #5

* cs 4.2 Appeases Codacy #4

* cs 3.8 Updated config.py
Gr3q pushed a commit that referenced this pull request Jun 30, 2022
@Borderliner
Fix left and right being the opposite in Persian (linuxmint#4360)
6166b41 
There two words are opposite in what they do. So when the system locale is set to Persian and everything is RTL, when you click left, the sidebar goes to right, and vice versa. This can possibly fix the issue.

Tested on:
LMDE 5.0 (Linux 5.10.0-14-amd64 #1 SMP Debian 5.10.113-1 (2022-04-29) x86_64 GNU/Linux)
Cinnamon 5.2.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dopeboy @Gr3q