-
Notifications
You must be signed in to change notification settings - Fork 48
feat: use jsdeliver instead of github url #687
Conversation
Signed-off-by: 0xMRTT <0xMRTT@proton.me>
since it's only doing build, we can call it build :) Signed-off-by: 0xMRTT <0xMRTT@proton.me> # Description <!-- Describe your changes in detail here. --> Fixes #(issue) ## Type of change <!-- What type of change does your pull request introduce? Put an `x` in the box that apply. --> - [ ] Bugfix (Change which fixes a issue) - [ ] New feature (Change which adds new functionality) - [ ] Enhancement (Change which slightly improves existing code) - [ ] Breaking change (This change will introduce incompatibility with existing functionality) ## Changelog <!-- This is optional, but highly appreciated. --> - Fixed … - Added … ## Testing - [ ] I have tested my changes and verified that they work as expected <!-- Required, your PR won't be accepted if you don't do this step. --> ### How to test the changes <!-- Optional, it can speed up review process if you provide the information on how to test your changes. --> No information provided. Signed-off-by: 0xMRTT <0xMRTT@proton.me>
Maybe we should inform users about using JSDeliver service? I don't think we need to do this in-app, but a small note section in readme would be good to add. |
maybe this is over-kill for our app? |
That can help to provide preset everytime, even if github goes down ... |
The idea with JSDeliver is good, but we should implement it in such a way that it will be opt-in to use. Users could go for example to preferences and toggle an option to enable it when GitHub (for example) goes down. |
Converted to draft, as we need to add this option to preferences window. |
Why? |
I think that's not necessary ... |
It isn't necessary, but it still would be useful if Github for example went down |
Currently translated at 100.0% (292 of 292 strings) Translation: Gradience/Gradience Translate-URL: https://hosted.weblate.org/projects/GradienceTeam/gradience/ar/
Currently translated at 92.1% (269 of 292 strings) Translation: Gradience/Gradience Translate-URL: https://hosted.weblate.org/projects/GradienceTeam/gradience/nl/
Currently translated at 100.0% (292 of 292 strings) Translation: Gradience/Gradience Translate-URL: https://hosted.weblate.org/projects/GradienceTeam/gradience/ta/
Currently translated at 100.0% (292 of 292 strings) Translation: Gradience/Gradience Translate-URL: https://hosted.weblate.org/projects/GradienceTeam/gradience/nl/
@daudix-UFO RFC for title and subtitle @tfuxu Request for code review |
First issue, can't start
|
Oh messed up when resolving the merge conflict 🤫 |
Signed-off-by: 0xMRTT <0xMRTT@proton.me>
I'll review the code tomorrow, as it's pretty late where I live, but from what I quickly tested, it looks and works fine |
* move some snippets to other modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me after a fix. I'd like to re-request @0xMRTT and @daudix-UFO for review to make sure it works properly on your machines too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine :)
Hmm, I think that there is one preset repos which is still using the hardcoded one but idk where it is since I'm not at home... |
Tried, and that's okay for me! |
Description
We can use JSDeliver for downloading files instead of directly getting them from github because:
Blocking
Type of change
Changelog
Testing