Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.yml: bump flatpak builder version #749

Merged
merged 1 commit into from Apr 6, 2023
Merged

build.yml: bump flatpak builder version #749

merged 1 commit into from Apr 6, 2023

Conversation

kbdharun
Copy link
Contributor

@kbdharun kbdharun commented Apr 2, 2023

Type of change

  • Bugfix (Change which fixes a issue)
  • New feature (Change which adds new functionality)
  • Enhancement (Change which slightly improves existing code)
  • Breaking change (This change will introduce incompatibility with existing functionality)

Testing

  • I have tested my changes and verified that they work as expected

How to test the changes

No information provided.

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome on Gradience. 🥳 We really appreciate your contribution. The core team will review your pull request as soon as possible. You can also join the Matrix room: https://matrix.to/#/#Gradience-space:envs.net or the Discord server: https://discord.com/invite/4njFDtfGEZ.

Copy link
Member

@tfuxu tfuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'll wait with merging your PR until all build workflows are finished

@tfuxu
Copy link
Member

tfuxu commented Apr 2, 2023

I'm putting your PR as a draft for now, as I want to investigate why aarch64 builds are taking so long to build.

@tfuxu tfuxu marked this pull request as draft April 2, 2023 13:43
@daudix
Copy link
Member

daudix commented Apr 6, 2023

Maybe I'm wrong but aarch64 builds are always long the first time, then it uses cache and builds fast (the build runs in vm so it slower)

@0xMRTT
Copy link
Member

0xMRTT commented Apr 6, 2023

Yes 👍

@kbdharun
Copy link
Contributor Author

kbdharun commented Apr 6, 2023

Maybe I'm wrong but aarch64 builds are always long the first time, then it uses cache and builds fast (the build runs in vm so it slower)

Oh, that is possible.

@tfuxu
Copy link
Member

tfuxu commented Apr 6, 2023

This is probably the culprit of this issue: flatpak/flatpak-github-actions@56ddaec. From what I understand checking test CIs, a new action run (not a re-run) should have a different cache key, which should fix this issue. I'll merge this PR to check if this is true.

@tfuxu tfuxu marked this pull request as ready for review April 6, 2023 12:37
@tfuxu tfuxu merged commit 0bfc938 into GradienceTeam:main Apr 6, 2023
4 of 5 checks passed
@kbdharun kbdharun deleted the patch-1 branch April 6, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants