This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
daudix
approved these changes
Jun 27, 2023
tfuxu
suggested changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bug still persists, but only in Flatpak Applications
pref group. From what I checked, it appears to be a bug in flatpak_overrides
module, I'll try to fix this
5 tasks
tfuxu
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge this as-is, the flatpak_overrides
bug will require much more work than I initially thought. After I started working more on my personal projects, I can now see how many mistakes I've made in that module 😅️
It's the LGTM time! |
@FineFindus Thanks a lot for all these fixes! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the Switches to use the
active
property, which controls both color and position, instead ofstate
, which only changes the switch color.It also sets the
activatable-widget
on the jsdeliver ActionRows allowing the user to click anywhere to activate the switch.Type of change
Changelog
Testing
How to test the changes