Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Feat/switch state #792

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Feat/switch state #792

merged 5 commits into from
Jun 27, 2023

Conversation

0xMRTT
Copy link
Member

@0xMRTT 0xMRTT commented Jun 27, 2023

Description

Changes the Switches to use the active property, which controls both color and position, instead of state, which only changes the switch color.

It also sets the activatable-widget on the jsdeliver ActionRows allowing the user to click anywhere to activate the switch.

Type of change

  • Bugfix (Change which fixes a issue)
  • New feature (Change which adds new functionality)
  • Enhancement (Change which slightly improves existing code)
  • Breaking change (This change will introduce incompatibility with existing functionality)

Changelog

  • Fixed a bug where Switches were not shown as active

Testing

  • I have tested my changes and verified that they work as expected

How to test the changes

  1. Open the preferences
  2. Notice how the switches have both the correct position and color

@0xMRTT 0xMRTT requested a review from daudix June 27, 2023 08:55
@tfuxu tfuxu self-requested a review June 27, 2023 11:54
Copy link
Member

@tfuxu tfuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#788 (comment)

This bug still persists, but only in Flatpak Applications pref group. From what I checked, it appears to be a bug in flatpak_overrides module, I'll try to fix this

Copy link
Member

@tfuxu tfuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this as-is, the flatpak_overrides bug will require much more work than I initially thought. After I started working more on my personal projects, I can now see how many mistakes I've made in that module 😅️

@daudix
Copy link
Member

daudix commented Jun 27, 2023

It's the LGTM time!

@0xMRTT 0xMRTT merged commit 07b8c5f into main Jun 27, 2023
5 checks passed
@0xMRTT 0xMRTT deleted the feat/switch-state branch June 27, 2023 12:54
@daudix
Copy link
Member

daudix commented Jun 27, 2023

@FineFindus Thanks a lot for all these fixes!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants