SDK autoinstall breaks when using AIR with Flex 4.6 #217
Comments
Rely on airsdk.xml instead of lib/adt.jar which happens to be present in some Flex SDK distributions (e.g. http://download.macromedia.com/pub/flex/sdk/flex_sdk_4.6.zip). While airsdk.xml hasn't always been present on air distributions, it has been bundled since air 3.2. Unfortunately there's no single file that has always been present and that is not present in all Flex distributions.
Rely on a special file created by GradleFX itself to determine if a particular SDK has already been installed (.air.sentry and .flex.sentry) instead of relying on files bundled by the SDK. This solves a couple of issues: * Some flex distributions bundle lib/adt.jar which was previously used to determine if the Air SDK was already installed (GradleFx#217) * There's no single file present in all Air SDKs that can be used to reliably determine if its installed * Interrupting the SDK auto install process (via ^C) will leave the SDK in a partially installed state and future runs of GradleFX will not attempt to fix that. As a small side effect, the first time the updated GradleFX is used, the SDK will be unpacked again, since these .sentry files will not be present.
|
PR has been merged. |
|
Little bit after the fact, but I noticed that Flex 4.6 does come bundled with the AIR SDK (see https://helpx.adobe.com/flash-builder/release-note/flex-4-6-sdk-release.html). So in fact the lib/adt.jar is a valid file to detect the AIR SDK. However, I do like your approach with the sentry files, as it allows one to overlay this specific Flex SDK with another AIR SDK (even while this is discouraged by Adobe). It also has a certain kind of clearness to it. So I will keep this, but with a fallback to the old approach in case the user specifies the Flex/AIR sdk manually with the 'flexhome' property. |
|
Fallback mechanism: 683d7aa |
|
Interesting about 4.6. It must be a really old version of air that is bundled, since the way I noticed that the Air SDK wasn't being downloaded was because the resulting SDK failed to compile my Air project (missing things like Event.SUSPEND which were added back in 3.3) Thanks for the merge. |
|
Probably because Flex 4.6 is also quite old by now, it's still from the Adobe days. Now that Flex is under the Apache flag I think it reached 4.14 already. |
When declaring the following flex sdk dependency:
the SDK autoinstall feature will fail to overlay the AIR SDK on top of the extracted Flex SDK.
This is because the Air Sdk installer looks for
lib/adt.jar, which happens to be present in this particular Flex SDK.The text was updated successfully, but these errors were encountered: