updating README #64
Merged
updating README #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akuhlens
reviewed
Oct 2, 2018
README.md
Outdated
| of times this value has been casted before. Grift's runtime also represents | ||
| values and types in a way that makes many operations on them that are related to | ||
| runtime checking very efficient. Our self-comparison performance evaluation | ||
| indicates that this approach increased performance substantially in compare to |
There was a problem hiding this comment.
in compare => in comparison to
akuhlens
reviewed
Oct 2, 2018
README.md
Outdated
| indicates that this approach increased performance substantially in compare to | ||
| our own implementation of the space-inefficient runtime. It also indicates that | ||
| the overhead of doing merging is not expensive. Furthermore, fully typed and | ||
| fully untyped code is competitive with OCaml, and Typed Racket, and with Chez |
There was a problem hiding this comment.
I would say "performs in the ball-park of" instead of "is competitive with". We are blatantly slower than typed racket, chez, and gambit.
deyaaeldeen
force-pushed
the
update-readme
branch
from
81e9b6a
to
43ec69e
Compare
akuhlens
approved these changes
Oct 2, 2018
deyaaeldeen
force-pushed
the
update-readme
branch
from
43ec69e
to
cd11684
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.