Convert site from Bootstrap4 to Bootstrap5 #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimJentzsch
previously requested changes
Jun 18, 2021
6 tasks
|
Just putting this comment here as a reminder to remove the testing form from the code |
* Replace JQuery in input file and error message code * Replace JQuery in form validation script * Fix event listeners and clean up code * Remove JQuery script * Use query selectors for easier iteration * Make error list clearing more efficient * Use template string literals instead of concatenation Co-authored-by: David Alexander <TheLonelyGhost@users.noreply.github.com> * Fix form labels being deleted when displaying form errors Co-authored-by: David Alexander <TheLonelyGhost@users.noreply.github.com>
|
Note to self: when this is deployed, we will have to manually fix the donations page. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: #145
Description:
Since we started working on this so long ago, it still uses bootstrap4 -- it's better to change over sooner rather than later so that we have fewer things to break. This PR:
Turns out that adblock lists are literally just looking for a script called
plausible.js, no matter where it's loaded from -- so on the recommendation of Plausible, we'll now self-host the script and I've changed the name topotentially.js, which, hilariously, is enough to make it load. I've also disabled it if you're logged into the site, since we don't really want to track page views on the edit pages.Screenshots:
Homepage:
Example page:
New form:
Engineering main page:
Engineering blog post detail:
Also adds a new feature where the name dynamically collapses on the engineering blog side for desktop -> tablet -> mobile.
Desktop:
Tablet:
Phone:
Checklist: