Remove JQuery from form validation code #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLonelyGhost
requested changes
Jun 18, 2021
Co-authored-by: David Alexander <TheLonelyGhost@users.noreply.github.com>
|
If I submit an empty form, all of the errors show up, but it also nukes all of the form input labels:
Expected behavior from #159
|
itsthejoker
requested changes
Jun 22, 2021
Good catch -- should be fixed now! |
TheLonelyGhost
approved these changes
Jun 23, 2021
itsthejoker
added a commit
that referenced
this pull request
Jun 25, 2021
* convert to bootstrap5 * add support for directing back to engineering when on engineering post * fix support for blog on mobile * add test form * Remove JQuery from form validation code (#160) * Replace JQuery in input file and error message code * Replace JQuery in form validation script * Fix event listeners and clean up code * Remove JQuery script * Use query selectors for easier iteration * Make error list clearing more efficient * Use template string literals instead of concatenation Co-authored-by: David Alexander <TheLonelyGhost@users.noreply.github.com> * Fix form labels being deleted when displaying form errors Co-authored-by: David Alexander <TheLonelyGhost@users.noreply.github.com> * remove test form Co-authored-by: Joe Kaufeld <joe@kenzie.academy> Co-authored-by: TimJentzsch <tim-jentzsch@gmx.de> Co-authored-by: David Alexander <TheLonelyGhost@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: N/A
Description:
This removes the JQuery used in the form validation code in #159. The functionality should be identical, to the best of my knowledge.
I also removed a potential attack vector for script injection and handling in case that the forms don't have the expected structure.
If we are to proceed with this, first move this PR and then #159.
Checklist: