Close & Destroy #32
Merged
Close & Destroy #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,7 @@ | |||
| }, | |||
| "main": "lib/jschan.js", | |||
| "scripts": { | |||
| "test": "mocha --recursive test 2>&1", | |||
| "test": "_mocha --recursive test", | |||
There was a problem hiding this comment.
Because of mochajs/mocha#1393
|
@mcollina How does this affect the websocket driver? lgtm otherwise |
|
Not much, it was a bug shared by all transports. I'm trying to fix the closing issue on graft, so that we can have a proper reconnect system on top of that. However that's not solved yet, tests passes here but not there :(. |
|
how can i help? it's the next thing i want to tackle in aetherboard. |
|
open a bug there with a stacktrace. Also, a test to reproduce will help a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented correctly session.close, session.destroy and channel.destroy.