Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YOffset attribute in Manual section cannot have negative value #1485

Closed
eturpault opened this issue Apr 20, 2023 · 1 comment · Fixed by #1488
Closed

YOffset attribute in Manual section cannot have negative value #1485

eturpault opened this issue Apr 20, 2023 · 1 comment · Fixed by #1488
Milestone

Comments

@eturpault
Copy link
Contributor

The attributes YOffset_KEYTYPE and Key999YOffset can be set at a value from 0 to 500. Negative Y offset value is not possible.
This doesn't permit to display correctly keyboards sharp keys of some Hauptwerk sample sets.

For example with the Prytanée sample set of Sonus Paradisi :
keyboard (on the left the expected display, on the right the obtained display with YOffset=0 instead of -10) :
comparatif claviers prytanée
pedal (on the left the expected display, on the right the obtained display with YOffset=0 instead of -56) :
comparatif pédalier prytanée

Same issue with for example Buckeburg and Noordbroek sample sets of Sonus Paradisi.

Could the YOffset accepted range be extented to negative values : -100 for example ?

@eturpault
Copy link
Contributor Author

Thanks @oleg68 for the implementation, I confirm that the keys can now be all displayed as expected with the sample sets that I tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants