Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipe999LoopCrossfadeLength and Pipe999ReleaseCrossfadeLength maximum value #1612

Closed
eturpault opened this issue Jul 25, 2023 · 0 comments · Fixed by #1619
Closed

Pipe999LoopCrossfadeLength and Pipe999ReleaseCrossfadeLength maximum value #1612

eturpault opened this issue Jul 25, 2023 · 0 comments · Fixed by #1619
Milestone
3.13.0

Comments

@eturpault
Copy link
Contributor

eturpault commented Jul 25, 2023 •
edited
Loading

The attributes Pipe999LoopCrossfadeLength and Pipe999ReleaseCrossfadeLength are limited respectively to 120ms and 200ms maximum in the ranks.
Some sample sets made for Hauptwerk can have such attributes going up to respectively 173ms and 305ms according to my observations.
I am not able to say how important is this attribute on the realism of the pipes sound rendering, but would it be worth / feasible to increase these maximum values to respectively 200 ms and 400ms for example so that OdfEdit could convert these attributes without having to clip them ?
@oleg68 oleg68 added the bug Something isn't working label Aug 1, 2023
@oleg68 oleg68 added this to the 3.12.3 milestone Aug 1, 2023
oleg68 added a commit to oleg68/GrandOrgue-official that referenced this issue Aug 1, 2023
@oleg68
Fixed maximum value of Pipe999LoopCrossfadeLength and Pipe999ReleaseC…
40d3b8e 
…rossfadeLength. Now they are 3000 GrandOrgue#1612
@oleg68 oleg68 mentioned this issue Aug 1, 2023
Merged
1 task
@larspalo larspalo removed the bug Something isn't working label Aug 5, 2023
oleg68 added a commit to oleg68/GrandOrgue-official that referenced this issue Aug 5, 2023
@oleg68
Fixed maximum value of Pipe999LoopCrossfadeLength and Pipe999ReleaseC…
1743a12 
…rossfadeLength. Now they are 3000 GrandOrgue#1612
@oleg68 oleg68 modified the milestones: 3.12.3, 3.13.0 Aug 9, 2023
oleg68 added a commit to oleg68/GrandOrgue-official that referenced this issue Aug 9, 2023
@oleg68
Fixed maximum value of Pipe999LoopCrossfadeLength and Pipe999ReleaseC…
7b4305d 
…rossfadeLength. Now they are 3000 GrandOrgue#1612
oleg68 added a commit to oleg68/GrandOrgue-official that referenced this issue Aug 14, 2023
@oleg68
Fixed maximum value of Pipe999LoopCrossfadeLength and Pipe999ReleaseC…
6b58e9c 
…rossfadeLength. Now they are 3000 GrandOrgue#1612
oleg68 added a commit to oleg68/GrandOrgue-official that referenced this issue Aug 16, 2023
@oleg68
Fixed maximum value of Pipe999LoopCrossfadeLength and Pipe999ReleaseC…
95d40fb 
…rossfadeLength. Now they are 3000 GrandOrgue#1612
oleg68 added a commit that referenced this issue Aug 16, 2023
@oleg68
Increased the maximum value of Pipe999LoopCrossfadeLength and Pipe999…
fd3ea7d 
…ReleaseCrossfadeLength. Now they are 3000 #1612 (#1619)
@eturpault eturpault mentioned this issue Nov 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.13.0
3 participants
@larspalo @oleg68 @eturpault