Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enchance Midi Settings #703

Closed
3 tasks done
oleg68 opened this issue Aug 18, 2021 · 4 comments · Fixed by #897
Closed
3 tasks done

Enchance Midi Settings #703

oleg68 opened this issue Aug 18, 2021 · 4 comments · Fixed by #897
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@oleg68
Copy link
Contributor

oleg68 commented Aug 18, 2021

Now GrandOrgue automatically enables all available midi devices and then allows to disable some of them in Midi Settings.

GO keeps the names of disabled midi devices.

Sometimes midi devices change their names across system restart. For example, the name of alsa device names contain the midi port number that depends on the device initialisation order and can vary. In this case the old device with the new name will be automatically enabled that may be not desirable.

I'm going to make the following changes:

  • Introduce a subsystem filter for devices (alsa, jack, core etc)
  • Introduce a settings Enable new devices automatically, by default enabled.
    matched by regex
  • Introduce the setting not to check midi on startup Choice for checking midi device #796

Some other midi enchancements will be done in #885

@oleg68 oleg68 transferred this issue from oleg68/GrandOrgue Sep 17, 2021
@rousseldenis rousseldenis added the enhancement New feature or request label Sep 21, 2021
@ajvdw
Copy link

ajvdw commented Sep 24, 2021

I'd like to enable/disable midi devices per RtMidi API (Jack, ALSA, etc?)

@oleg68
Copy link
Contributor Author

oleg68 commented Sep 24, 2021

@ajvdw I've added it to the to-do list

@oleg68
Copy link
Contributor Author

oleg68 commented Nov 20, 2021

@rousseldenis @larspalo

Because this issue is not obvious, we need to discuss it. I'd ask you to post your thoughs and suggestions here.

oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 20, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 20, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 20, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 20, 2021
@larspalo
Copy link
Contributor

The issue of (USB) MIDI devices changing names is not new. In rev 2174 Martin actually patched RtMidi because it's really a big part of the issue. With the updates to RtMidi those patches may long be gone now (I'm not certain if they were merged upstream or not). If the same effect can be achieved with regex comparison of devices it's all fine and dandy. But if possible, the list of devices should not name them so that any confusion will be created even if the port number changes but match the stored device to what the system presents, ideally in such a way that the user will never notice it. Otherwise it seems to be a good idea to enable a subsystem filter so that a lot of the "noise" caused by probing at startup can be eliminated once a working setup is achieved.

@oleg68 oleg68 self-assigned this Nov 20, 2021
@oleg68 oleg68 added this to the 3.5.0 milestone Nov 20, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 22, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 22, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 22, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 22, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 22, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 27, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 27, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 27, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 27, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 27, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 27, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 29, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 29, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 29, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 29, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 29, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 29, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 29, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 29, 2021
Separated constructing controls and filling with values GrandOrgue#703
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 29, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 30, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 30, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 30, 2021
Extracted GOSettingsPorts from SettingsAudioOutput GrandOrgue#703
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 30, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 30, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 30, 2021
Separated constructing controls and filling with values GrandOrgue#703
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 30, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 30, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 30, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 30, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 30, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 30, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Nov 30, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Dec 4, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Dec 4, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Dec 4, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Dec 4, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Dec 4, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Dec 4, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Dec 4, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Dec 4, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants