Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate issuing of releases #711

Closed
oleg68 opened this issue Sep 19, 2021 · 5 comments · Fixed by #759
Closed

Automate issuing of releases #711

oleg68 opened this issue Sep 19, 2021 · 5 comments · Fixed by #759
Assignees

Comments

@oleg68
Copy link
Contributor

oleg68 commented Sep 19, 2021

Now the process of issuing of releases is the following

  1. Create a release tag and push it to master
  2. Wait when the release auto build creates the release on github and update its description manually with the CHANGELOG.md contents

(1) was acceptable when GO was hosted in a private repository. But working with organisation means no direct access to the GO repositories (I disable it in my git settings for prudence) and making all changes in own fork with creating a pull request. But Github does not allow PR on tags. It requires to enable direct access to the target repo temporary.

Moreover issuing releases should have aproval from other members. Tagging does not allow this.

(2) requires manual actions and may be done incorrectly.

My approach of the new process is the following:

  1. Add the new release label on top of CHANGELOG.md
  2. Make a ususa PR with the only change in this file
  3. After approval and merging this PR all futher steps should be made authomatically, including putting the version tag.

@larspalo @rousseldenis how do you find the new process?

@rousseldenis
Copy link
Contributor

In the processes I'm used to, people that have write access will create releases.

Usually, updating the changelog and using tags. IMHO, the use of tags should be mandatory as they allow to freeze a version.

Concerning the approval of other members, maybe yes or maybe not, I'm not sure this will help in the flow.

PS: A little tool that helps releases is bumpversion. It allows to modify several files at once with --patch/minor/major commands.

@rousseldenis
Copy link
Contributor

Usually, updating the changelog and using tags. IMHO, the use of tags should be mandatory as they allow to freeze a version

And the main aim too is that allows to get back to that version if master is in a mess.

@oleg68
Copy link
Contributor Author

oleg68 commented Sep 19, 2021

IMHO, the use of tags should be mandatory as they allow to freeze a version.

I suggest the build script to read the first line of CHANGELOG.md and to put the tag authomatically. Not to put the version tag manually.

@rousseldenis
Copy link
Contributor

IMHO, the use of tags should be mandatory as they allow to freeze a version.

I suggest the build script to read the first line of CHANGELOG.md and to put the tag authomatically. Not to put the version tag manually.

Of course, if we can make our path in order to get them automatically, let's go

@larspalo
Copy link
Contributor

I like the process Oleg suggests.

@oleg68 oleg68 self-assigned this Sep 28, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 7, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 7, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 7, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 7, 2021
oleg68 pushed a commit to oleg68/GrandOrgue-official that referenced this issue Oct 7, 2021
@oleg68 oleg68 mentioned this issue Oct 7, 2021
@oleg68 oleg68 mentioned this issue Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants