Added support of macOS on Apple Silicon #1864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
willeke1234
commented
Apr 5, 2024
•
willeke1234
commented
- Added Github build for macOS on Apple silicon, resolves GrandOrgue release for Apple chips #1153
- Added ad-hoc code signing of GrandOrgue for macOS, resolves Sign GrandOrgue for MacOS #1835
- Updated info.plist (this is an application properties file in macOS apps)
- Updated the macOS sections of BUILD.md, INSTALL.md and README.md
macOS file Info.plist was outdated
Fixed code signing app on .dmg Name of .dmg contains macOS instead of osx
To run on push uncomment on:
Updated macOS build instructions
Changed the case of commands for better readability
Updated INSTALL.md and README.md for macOS. OS X is now called macOS.
oleg68
requested changes
Apr 6, 2024
The code sign instructions are now in cmake/SignMacOSApp.cmake
oleg68
requested changes
Apr 7, 2024
oleg68
reviewed
Apr 7, 2024
oleg68
reviewed
Apr 7, 2024
.DS_Store is a macOS file that stores custom attributes of its containing folder
oleg68
approved these changes
Apr 8, 2024
larspalo
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.