Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks cd command behavior in shell #1

Closed
fisadev opened this issue Jul 26, 2016 · 3 comments
Closed

Breaks cd command behavior in shell #1

fisadev opened this issue Jul 26, 2016 · 3 comments

Comments

@fisadev
Copy link

fisadev commented Jul 26, 2016

Activating this xontrib breaks the behavior of cd without arguments, as explained in this xonsh issue: xonsh/xonsh#1484
In the comments, near the end, the culprit line in autoxsh is specified (related to an import).

@PaulReiber
Copy link

If I'm right this should be a super easy fix.

instead of:
from xonsh.dirstack import cd

we would rename cd on the way in:
from xonsh.dirstack import cd as _cd

then 7 lines below that:
rtn = _cd(args, stdin=stdin)

Kind regards,

_Paul Reiber_http://about.me/reiber

On Mon, Jul 25, 2016 at 10:18 PM, Juan Pedro Fisanotti <
notifications@github.com> wrote:

Activating this xontrib breaks the behavior of cd without arguments, as
explained in this xonsh issue: xonsh/xonsh#1484
xonsh/xonsh#1484
In the comments, near the end, the culprit line in autoxsh is specified
(related to an import).


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1, or mute the thread
https://github.com/notifications/unsubscribe-auth/AADlQNMZaFmQqdiyfz6AVqTfIeVXRzcvks5qZZicgaJpZM4JUyvy
.

@fisadev
Copy link
Author

fisadev commented Jul 26, 2016

PR done, thanks @PaulReiber for the info on how to fix it. Hope they merge it :)

@Granitosaurus
Copy link
Owner

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants