Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template and CHANGELOG #1

Merged
merged 3 commits into from
Sep 30, 2019
Merged

Add PR template and CHANGELOG #1

merged 3 commits into from
Sep 30, 2019

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Sep 28, 2019

After this PR, each new PR will have a PR template to fill out (like below). Each PR also requires one approving review in order to be merged so whenever it's ready just request a review and we'll take it from there.

Pull request

Please confirm that this pull request has done the following:

  • Tests added (N/A)
  • Documentation added (where applicable) (N/A)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/znicholls/silicone/issues/YY>`_)

@codecov
Copy link

codecov bot commented Sep 28, 2019

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #1   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines           5      5           
=====================================
  Hits            5      5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8658f6...0d2b8dc. Read the comment docs.

@Rlamboll Rlamboll merged commit 300d163 into master Sep 30, 2019
@Rlamboll Rlamboll deleted the pr-template branch October 4, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants