-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve release docs #101
Improve release docs #101
Conversation
53264ba
to
2975054
Compare
Questions for @Rlamboll and @jkikstra on top of general review:
You can see the CI-CD pipeline doing it's thing in the pipelines for the v0.1.0rc tag and the 0.2.0 tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a lot simpler than before!
|
It doesn't actually pass the tests however, I get (I have openscm-units installed in this env and this persists even if I revert to openscm-units 0.1.1, which is what I was previously using.) Will have another look in the morning. |
As in |
I wasn't running make because windows. I've tried it again and it works now, so I'm not sure what the problem was (I cleared the cache). Anyway, it seems to work for Joeri when installed everything from scratch, so presumably a problem connected to conda recovering old versions of files somehow? |
Ye weird, sometimes things don’t reinstall properly unless you start fresh.. |
2975054
to
96cf6d6
Compare
OK @znicholls, I don't think Jarmo is going to review this so merge them at will |
81932f6
to
4fbab74
Compare
Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rst
addedAdding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following: