-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More warnings #113
More warnings #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks tidy!
OK, while we're sorting out the logging I've decided to both log and print these warnings and I've done the same thing now for the other ratio methods. I think this is the last change particularly requested by reviewers, so unless you have something else to complete soon I was planning to finalise this as v1.0.0 |
To make your life easy, I would just do another release candidate (or beta version) and only do v1.0.0 once the paper has been accepted. We might be able to sort out logging before then too which would be good. |
Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rst
addedAdding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following: