Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More warnings #113

Merged
merged 13 commits into from
Aug 13, 2020
Merged

More warnings #113

merged 13 commits into from
Aug 13, 2020

Conversation

Rlamboll
Copy link
Collaborator

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/GranthamImperial/silicone/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/GranthamImperial/silicone/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/GranthamImperial/silicone/issues/YY>`_)

Copy link
Collaborator

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks tidy!

@Rlamboll
Copy link
Collaborator Author

OK, while we're sorting out the logging I've decided to both log and print these warnings and I've done the same thing now for the other ratio methods. I think this is the last change particularly requested by reviewers, so unless you have something else to complete soon I was planning to finalise this as v1.0.0

@znicholls
Copy link
Collaborator

unless you have something else to complete soon I was planning to finalise this as v1.0.0

To make your life easy, I would just do another release candidate (or beta version) and only do v1.0.0 once the paper has been accepted. We might be able to sort out logging before then too which would be good.

@Rlamboll Rlamboll merged commit 1e87418 into master Aug 13, 2020
@Rlamboll Rlamboll deleted the more_warnings branch August 13, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants