Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update black #116

Merged
merged 8 commits into from
Sep 9, 2020
Merged

Update black #116

merged 8 commits into from
Sep 9, 2020

Conversation

Rlamboll
Copy link
Collaborator

@Rlamboll Rlamboll commented Sep 8, 2020

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/GranthamImperial/silicone/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/GranthamImperial/silicone/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/GranthamImperial/silicone/issues/YY>`_)

@Rlamboll
Copy link
Collaborator Author

Rlamboll commented Sep 9, 2020

Apparently someone pushed an update to black that changes how it executes and makes it incompatible with black-nb (quiet crying)

@znicholls
Copy link
Collaborator

Yes I had the same in other repos, not ideal. Thanks for fixing

CHANGELOG.rst Outdated Show resolved Hide resolved
Co-authored-by: Zeb Nicholls <zebedee.nicholls@climate-energy-college.org>
@Rlamboll Rlamboll merged commit 5e84e4d into master Sep 9, 2020
@Rlamboll Rlamboll deleted the update_black branch September 9, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants