Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for pyam 07 #119

Merged
merged 21 commits into from
Oct 27, 2020
Merged

Update for pyam 07 #119

merged 21 commits into from
Oct 27, 2020

Conversation

Rlamboll
Copy link
Collaborator

@Rlamboll Rlamboll commented Oct 8, 2020

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/GranthamImperial/silicone/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/GranthamImperial/silicone/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/GranthamImperial/silicone/issues/YY>`_)

@Rlamboll
Copy link
Collaborator Author

Since the new version of pyam is buggy, unless anyone objects this update will be written so as to be backwards-compatible rather than removing deprecated .scenarios() etc. commands.

CHANGELOG.rst Outdated Show resolved Hide resolved
src/silicone/utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of tweaks but otherwise all good

Rlamboll and others added 3 commits October 25, 2020 22:04
Co-authored-by: Zeb Nicholls <zebedee.nicholls@climate-energy-college.org>
@znicholls znicholls self-requested a review October 26, 2020 23:21
@Rlamboll Rlamboll merged commit 4c03fb9 into master Oct 27, 2020
@Rlamboll Rlamboll deleted the update_pyam_07 branch October 27, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants