Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new openscm-units API #121

Merged
merged 4 commits into from Jan 1, 2021
Merged

Update to new openscm-units API #121

merged 4 commits into from Jan 1, 2021

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Dec 23, 2020

Pull request

Please confirm that this pull request has done the following:

  • Tests added (N/A)
  • Documentation added (where applicable) (N/A)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/GranthamImperial/silicone/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/GranthamImperial/silicone/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/GranthamImperial/silicone/issues/YY>`_)

@znicholls
Copy link
Collaborator Author

znicholls commented Dec 23, 2020

Solves our failing pypi install (https://github.com/GranthamImperial/silicone/actions/runs/439203228) once we do a new release

setup.py Show resolved Hide resolved
@znicholls znicholls merged commit 2bc6747 into master Jan 1, 2021
@znicholls znicholls deleted the hotfix-install branch January 1, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants