-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert plotter to cli #13
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
========================================
- Coverage 100% 93.9% -6.1%
========================================
Files 5 8 +3
Lines 69 246 +177
Branches 8 41 +33
========================================
+ Hits 69 231 +162
- Misses 0 11 +11
- Partials 0 4 +4
Continue to review full report at Codecov.
|
1c8adab
to
bc00b9d
Compare
c7315e0
to
c3231bd
Compare
@Rlamboll this is ready for review. I would suggest we do this and then do #14/#15 as there's a few things in here which will be useful there. As it stands it's a bit rough, but I can't actually do any better until we work out how to test the rolling windows quantile cruncher so I think we should just merge this and fix it up when we address #16. |
Python 3.5 seems to not play ball with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several parts of this will need patching before we continue (in particular checks for the statistics for the cruncher) but it's easier to do that as a separate patch now.
Work still needed for more tests, but to be done as a separate pull request. |
Pull request
Follows #9
Please confirm that this pull request has done the following:
CHANGELOG.rst
addedAdding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following:
@Rlamboll this is my first step of putting #11 into the package.