Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert plotter to cli #13

Merged
merged 21 commits into from
Oct 24, 2019
Merged

Convert plotter to cli #13

merged 21 commits into from
Oct 24, 2019

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Oct 15, 2019

Pull request

Follows #9

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A as not production ready yet, see Testing quantile rolling windows cruncher #16)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/znicholls/silicone/issues/YY>`_)

@Rlamboll this is my first step of putting #11 into the package.

@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #13 into master will decrease coverage by 6.09%.
The diff coverage is 92.06%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #13     +/-   ##
========================================
- Coverage     100%   93.9%   -6.1%     
========================================
  Files           5       8      +3     
  Lines          69     246    +177     
  Branches        8      41     +33     
========================================
+ Hits           69     231    +162     
- Misses          0      11     +11     
- Partials        0       4      +4
Impacted Files Coverage Δ
src/silicone/database_crunchers/base.py 100% <100%> (ø) ⬆️
src/silicone/utils.py 100% <100%> (ø) ⬆️
src/silicone/cli.py 100% <100%> (ø)
src/silicone/database_crunchers/lead_gas.py 100% <100%> (ø) ⬆️
src/silicone/database_crunchers/__init__.py 100% <100%> (ø) ⬆️
...one/database_crunchers/quantile_rolling_windows.py 87.5% <87.5%> (ø)
src/silicone/plotting.py 92.68% <92.68%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99a95eb...0b04dfb. Read the comment docs.

@znicholls znicholls changed the title WIP: Convert plotter to cli Convert plotter to cli Oct 23, 2019
@znicholls znicholls marked this pull request as ready for review October 23, 2019 09:03
@znicholls
Copy link
Collaborator Author

@Rlamboll this is ready for review. I would suggest we do this and then do #14/#15 as there's a few things in here which will be useful there.

As it stands it's a bit rough, but I can't actually do any better until we work out how to test the rolling windows quantile cruncher so I think we should just merge this and fix it up when we address #16.

@znicholls
Copy link
Collaborator Author

Python 3.5 seems to not play ball with os.path.join so I'm going to suggest we drop support for that here too.

Copy link
Collaborator

@Rlamboll Rlamboll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several parts of this will need patching before we continue (in particular checks for the statistics for the cruncher) but it's easier to do that as a separate patch now.

@Rlamboll Rlamboll closed this Oct 24, 2019
@Rlamboll Rlamboll reopened this Oct 24, 2019
@Rlamboll
Copy link
Collaborator

Work still needed for more tests, but to be done as a separate pull request.

@Rlamboll Rlamboll merged commit ca995de into master Oct 24, 2019
@Rlamboll Rlamboll deleted the explorer-cli branch October 24, 2019 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants