Rms closest cruncher

[Rlamboll]

Pull request

Please confirm that this pull request has done the following:

• Tests added
• Documentation added (where applicable)
• Example added (either to an existing notebook or as a new notebook, where applicable)
• Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/znicholls/silicone/issues/YY>`_)

[codecov]

Codecov Report

Merging #14 into master will increase coverage by 1.32%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage    93.9%   95.22%   +1.32%     
==========================================
  Files           8        9       +1     
  Lines         246      314      +68     
  Branches       41       52      +11     
==========================================
+ Hits          231      299      +68     
  Misses         11       11              
  Partials        4        4

Impacted Files	Coverage Δ
src/silicone/database_crunchers/rms_closest.py	100% <100%> (ø)
src/silicone/database_crunchers/__init__.py	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca995de...6c5047a. Read the comment docs.

[znicholls]

Looks good! If you re-run, save and commit the notebook, the tests should pass I think and then I'll do a better review.

[znicholls]

@Rlamboll if it's helpful I had a go at rebasing this (https://github.com/znicholls/silicone/tree/RMS-closest-cruncher-rebase). Let me know if you have any problems.

[znicholls]

Looks good @Rlamboll ! A few comments (plus the one above which is outside the review for some reason oops) and I think you just need to add a tdb attribute to the RMS tester (like https://github.com/znicholls/silicone/blob/ad6308805fa67ab3c308b02ccf397c37614f50f0/tests/integration/crunchers/test_cruncher_rms_closest.py#L17). The other thing it would be great to do before committing is the commands called by make format. make format won't work on windows but hopefully the Makefile is clear enough? If not, ping me and we can work something out.

[znicholls]

Nice @Rlamboll !!