-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quantile ratio 2 #47
Quantile ratio 2 #47
Conversation
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=========================================
+ Coverage 98.39% 98.4% +0.01%
=========================================
Files 17 17
Lines 746 753 +7
Branches 155 158 +3
=========================================
+ Hits 734 741 +7
Misses 7 7
Partials 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice! Good to see infilling method implemented!
(some extra descriptions for the tests would be nice, I've pointed out one which would especially be worthwhile putting down one line because it is relatively long)
@@ -113,12 +114,22 @@ def test_derive_relationship_with_multicolumns(self): | |||
"Emissions|CO2", ["Emissions|CH4", "Emissions|HFC|C5F12"] | |||
) | |||
|
|||
def test_relationship_usage(self, simple_df): | |||
@pytest.mark.parametrize("use_ratio", [True, False]) | |||
def test_relationship_usage(self, simple_df, use_ratio, caplog): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a description here would be useful as this test is relatively long and captures different points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some added
Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rst
addedAdding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following: