Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantile ratio 2 #47

Merged
merged 5 commits into from Feb 27, 2020
Merged

Quantile ratio 2 #47

merged 5 commits into from Feb 27, 2020

Conversation

Rlamboll
Copy link
Collaborator

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/znicholls/silicone/issues/YY>`_)

@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #47 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #47      +/-   ##
=========================================
+ Coverage   98.39%   98.4%   +0.01%     
=========================================
  Files          17      17              
  Lines         746     753       +7     
  Branches      155     158       +3     
=========================================
+ Hits          734     741       +7     
  Misses          7       7              
  Partials        5       5
Impacted Files Coverage Δ
src/silicone/stats.py 100% <ø> (ø) ⬆️
...one/database_crunchers/quantile_rolling_windows.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83b361a...10e0c5f. Read the comment docs.

Copy link
Collaborator

@jkikstra jkikstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Good to see infilling method implemented!

(some extra descriptions for the tests would be nice, I've pointed out one which would especially be worthwhile putting down one line because it is relatively long)

@@ -113,12 +114,22 @@ def test_derive_relationship_with_multicolumns(self):
"Emissions|CO2", ["Emissions|CH4", "Emissions|HFC|C5F12"]
)

def test_relationship_usage(self, simple_df):
@pytest.mark.parametrize("use_ratio", [True, False])
def test_relationship_usage(self, simple_df, use_ratio, caplog):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a description here would be useful as this test is relatively long and captures different points.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some added

@Rlamboll Rlamboll merged commit 3c445e8 into master Feb 27, 2020
@Rlamboll Rlamboll deleted the quantile_ratio_2 branch February 27, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants