Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install docs #60

Merged
merged 4 commits into from
Mar 19, 2020
Merged

Update install docs #60

merged 4 commits into from
Mar 19, 2020

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Mar 18, 2020

Pull request

Please confirm that this pull request has done the following:

  • Tests added (N/A)
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable) (N/A)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Added feature which does something
- (`#XX <https://github.com/znicholls/silicone/pull/XX>`_) Fixed bug identified in (`#YY <https://github.com/znicholls/silicone/issues/YY>`_)

Closes #53

@znicholls znicholls marked this pull request as ready for review March 18, 2020 23:48
@znicholls znicholls requested a review from Rlamboll March 18, 2020 23:48
@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #60 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files          18       18           
  Lines         788      788           
  Branches      166      166           
=======================================
  Hits          774      774           
  Misses          8        8           
  Partials        6        6           
Impacted Files Coverage Δ
src/silicone/utils.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00e8ca6...17fd072. Read the comment docs.

@znicholls znicholls requested a review from jkikstra March 18, 2020 23:54
Copy link
Collaborator

@jkikstra jkikstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers.

README.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@Rlamboll Rlamboll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do with an extra comma, otherwise looks good.

znicholls and others added 4 commits March 20, 2020 09:59
Co-Authored-By: Rlamboll <rlamboll@hotmail.co.uk>
@znicholls
Copy link
Collaborator Author

@Rlamboll gtg ?

@Rlamboll
Copy link
Collaborator

Yep

@Rlamboll Rlamboll merged commit 07c9e31 into master Mar 19, 2020
@Rlamboll Rlamboll deleted the update-installation-docs branch March 19, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation
3 participants