Modify quantile method to provide smoother results #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 1, 2020 23:40
Rlamboll
force-pushed
the
modify_quantile
branch
from
8c1ecc0
to
3a3999c
Compare
znicholls
reviewed
Apr 2, 2020
| @@ -4,6 +4,7 @@ Changelog | |||
| master | |||
| ------ | |||
|
|
|||
| - (`#78 <https://github.com/znicholls/silicone/pull/78>`_) Changed how quantile rolling windows works by adding an extra interpolate step for smoothness | |||
There was a problem hiding this comment.
Suggested change
| - (`#78 <https://github.com/znicholls/silicone/pull/78>`_) Changed how quantile rolling windows works by adding an extra interpolate step for smoothness | |
| - (`#78 <https://github.com/znicholls/silicone/pull/78>`_) Updated ``DatabaseCruncherQuantileRollingWindows `` to use an extra interpolate step for smoothness |
There was a problem hiding this comment.
The maths is super-fiddly, it should be ok though.
znicholls
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rstaddedAdding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following: