-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aarch64 executable tests #772
Conversation
I had to install staticx manually as root before, but I think it is a matter of my testing environment, so I decided not to add this change to this PR. If the problem turns out to be aarch64 specific, I'll add this installation to the tests/test.sh file. |
It doesn't make sense to me that specifically the "not_privileged" tests will fail on Aarch64, this is most likely something with the environment |
if precompiled is not None: | ||
return Path(precompiled) | ||
|
||
with chdir(PARENT): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, we are removing it here bcause this diverges from the pyi.Dockerfile. We follow the dockerfile build, not the logic here.
I ran this on my Aarch64 server:
and got:
Will merge this soon |
Well, the Aarch64 executable pyperf test is marked as passing
because |
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots
Checklist: