Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aarch64 executable tests #772

Merged
merged 4 commits into from
Apr 16, 2023
Merged

Conversation

pfilipko1
Copy link
Collaborator

@pfilipko1 pfilipko1 commented Apr 13, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots

Checklist:

  • I have read the CONTRIBUTING document.
  • I have updated the relevant documentation.
  • I have added tests for new logic.

@pfilipko1
Copy link
Collaborator Author

I had to install staticx manually as root before, but I think it is a matter of my testing environment, so I decided not to add this change to this PR. If the problem turns out to be aarch64 specific, I'll add this installation to the tests/test.sh file.

@Jongy
Copy link
Contributor

Jongy commented Apr 13, 2023

It doesn't make sense to me that specifically the "not_privileged" tests will fail on Aarch64, this is most likely something with the environment

if precompiled is not None:
return Path(precompiled)

with chdir(PARENT):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, we are removing it here bcause this diverges from the pyi.Dockerfile. We follow the dockerfile build, not the logic here.

@Jongy
Copy link
Contributor

Jongy commented Apr 15, 2023

I ran this on my Aarch64 server:

sudo ./tests/test.sh --executable build/aarch64/gprofiler

and got:

=========================================================== 184 passed, 26 skipped, 27 xfailed, 676 warnings in 2397.70s (0:39:57) ===========================================================

Will merge this soon

@Jongy
Copy link
Contributor

Jongy commented Apr 16, 2023

Well, the Aarch64 executable pyperf test is marked as passing

tests/test_executable.py::test_executable[False-python-pyperf] PASSED                                                                                                                  [ 18%]

because PythonProfiler implicitly falls back to py-spy despite pyperf being requested, this needs to be fixed + the test should check for kernel + native stacks like the container test. I'll fix in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants