-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: types are changed to any
in v0.21.1
#5053
Comments
Thanks @ngoc199 please let me know if there are others missing declarations from the previous versions |
artf
added a commit
that referenced
this issue
May 2, 2023
* fix for when no implicit type (#4903) fix for no implicit type Co-authored-by: Sergio Wilson <sergio.wilson@foxpoint.com> * Fix broken links in the docs (#4914) * moved repo from artf to GrapesJS 1st pass * exceptions * Fix typing of trigger to include `args` (#4910) * Fix typing of trigger to include `args` * Update index.d.ts I don't even know how this got here haha * Remove ComponentLabelView hotfix for the tagName * TS Types: Extends the type of property that scripts/styles can takes (#4924) chore(types): Extends the type of property that scripts and styles can take * Convert Trait test into TS (#4899) Co-authored-by: Artur Arseniev <artur.catch@hotmail.it> * Clear deferred stuff on editor destroy. Fixes #4940 * Remove unused stuff from Editor * Add new `noCustom` option to `Component.getName()` * Up jsdoc * Add `rename` method to SelectorManager * Use rename in ClassTagView * Add duplicateSelected * Update Components.md (#4952) Grammer correction for Component Recognition and Component Type Stack section * Fix typos * docs: Fix a few typos (#4957) There are small typos in: - docs/api/selector.md - docs/api/storage_manager.md - docs/modules/Blocks.md - docs/modules/Components.md - docs/modules/I18n.md - docs/modules/Storage.md - docs/modules/Traits.md Fixes: - Should read `argument` rather than `argumnet`. - Should read `with` rather than `wiht`. - Should read `redundant` rather than `redundent`. - Should read `propagation` rather than `propogation`. - Should read `performances` rather than `perfomances`. - Should read `implementation` rather than `implemenation`. - Should read `contributors` rather than `contributos`. - Should read `attached` rather than `attacched`. Signed-off-by: Tim Gates <tim.gates@iress.com> * Fix broken links in the docs (#4963) * docs: Fix broken link of Storage * docs: Fix broken link of Blocks * docs: Fix broken link of Style-manager * docs: Fix broken link of Commands * docs: Fix broken link of Assets --------- Co-authored-by: Artur Arseniev <artur.catch@hotmail.it> * Fix link in Assets doc * Fix slider in StyleManager. Closes #4965 * Fix checkbox trait values on undo/redo. Closes #4972 * Add `fetchOptions` to AssetManager configs * Fix sorter placeholder with grid elements. Closes #4991 * Module cleanup (#4985) * module cleanup * Fix ?? --------- Co-authored-by: Artur Arseniev <artur.catch@hotmail.it> * improve typing (#5010) * Add options to ExportTemplate command * Fix showOffsetsSelected. Closes #4998 * fix: resolved bug with top/left being sticky when resizing from l/t side * Prevent top/left update if not in standard drag mode * Up Resizer dim values * Up key for the partial update * Build * Up docs * Add TS * Remove previous index.d.ts * Update README links * Add getValue/setValue to Trait * Improve TS for `Components.addType`. Closes #5053 --------- Signed-off-by: Tim Gates <tim.gates@iress.com> Co-authored-by: Sergio Wilson <wilsonsergio2500@gmail.com> Co-authored-by: Sergio Wilson <sergio.wilson@foxpoint.com> Co-authored-by: Alex Hoyau <a.hoyau@silexlabs.org> Co-authored-by: Zach Sadler <zaxcoding@gmail.com> Co-authored-by: Esteban Gonzalez <32603471+estebgonza@users.noreply.github.com> Co-authored-by: Alex Ritter <alex@undo.app> Co-authored-by: jacobisknight <jacob@sotechworks.com> Co-authored-by: Tim Gates <tim.gates@iress.com> Co-authored-by: Himansh <77732259+himansh-gjr@users.noreply.github.com> Co-authored-by: Singwai Chan <c.singwai@gmail.com> Co-authored-by: Paul Rill <paulrill2000@outlook.com>
pety-dc
pushed a commit
to d-code-ltd/grapesjs
that referenced
this issue
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
GrapesJS version
What browser are you using?
FireFox 112.0 (64-bit)
Reproducible demo link
No demo link
Describe the bug
I recently upgraded from v0.20.1 to v0.21.1.
A lot of types that existed in v0.20.1 are changed to
any
in v0.21.1.For example,
Type of
Components.addType
in v0.20.1 isAddComponentOptions
Type
Components
is changed toComponentManager
. Type ofComponentManager.addType
in v0.21.1 isany
How to reproduce the bug?
any
typeWhat is the expected behavior?
The types are defined as the previous version, not
any
.What is the current behavior?
The types are defined as
any
.If is necessary to execute some code in order to reproduce the bug, paste it here below:
Code of Conduct
The text was updated successfully, but these errors were encountered: