Fix typing of trigger to include args
#4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artf
requested changes
Feb 7, 2023
There was a problem hiding this comment.
Thanks @Zaxcoding this file is kind of temporary declaration and will be deprecated once we'll release the declaration generated directly from code, but at the moment I accept PRs here anyway.
In your changes you have to rollback GrapesEvent as there is no EditorEvent in this file.
I don't even know how this got here haha
|
Sorry about that, I think |
artf
approved these changes
Feb 10, 2023
|
Thank you Zach |
artf
added a commit
that referenced
this pull request
May 2, 2023
* fix for when no implicit type (#4903) fix for no implicit type Co-authored-by: Sergio Wilson <sergio.wilson@foxpoint.com> * Fix broken links in the docs (#4914) * moved repo from artf to GrapesJS 1st pass * exceptions * Fix typing of trigger to include `args` (#4910) * Fix typing of trigger to include `args` * Update index.d.ts I don't even know how this got here haha * Remove ComponentLabelView hotfix for the tagName * TS Types: Extends the type of property that scripts/styles can takes (#4924) chore(types): Extends the type of property that scripts and styles can take * Convert Trait test into TS (#4899) Co-authored-by: Artur Arseniev <artur.catch@hotmail.it> * Clear deferred stuff on editor destroy. Fixes #4940 * Remove unused stuff from Editor * Add new `noCustom` option to `Component.getName()` * Up jsdoc * Add `rename` method to SelectorManager * Use rename in ClassTagView * Add duplicateSelected * Update Components.md (#4952) Grammer correction for Component Recognition and Component Type Stack section * Fix typos * docs: Fix a few typos (#4957) There are small typos in: - docs/api/selector.md - docs/api/storage_manager.md - docs/modules/Blocks.md - docs/modules/Components.md - docs/modules/I18n.md - docs/modules/Storage.md - docs/modules/Traits.md Fixes: - Should read `argument` rather than `argumnet`. - Should read `with` rather than `wiht`. - Should read `redundant` rather than `redundent`. - Should read `propagation` rather than `propogation`. - Should read `performances` rather than `perfomances`. - Should read `implementation` rather than `implemenation`. - Should read `contributors` rather than `contributos`. - Should read `attached` rather than `attacched`. Signed-off-by: Tim Gates <tim.gates@iress.com> * Fix broken links in the docs (#4963) * docs: Fix broken link of Storage * docs: Fix broken link of Blocks * docs: Fix broken link of Style-manager * docs: Fix broken link of Commands * docs: Fix broken link of Assets --------- Co-authored-by: Artur Arseniev <artur.catch@hotmail.it> * Fix link in Assets doc * Fix slider in StyleManager. Closes #4965 * Fix checkbox trait values on undo/redo. Closes #4972 * Add `fetchOptions` to AssetManager configs * Fix sorter placeholder with grid elements. Closes #4991 * Module cleanup (#4985) * module cleanup * Fix ?? --------- Co-authored-by: Artur Arseniev <artur.catch@hotmail.it> * improve typing (#5010) * Add options to ExportTemplate command * Fix showOffsetsSelected. Closes #4998 * fix: resolved bug with top/left being sticky when resizing from l/t side * Prevent top/left update if not in standard drag mode * Up Resizer dim values * Up key for the partial update * Build * Up docs * Add TS * Remove previous index.d.ts * Update README links * Add getValue/setValue to Trait * Improve TS for `Components.addType`. Closes #5053 --------- Signed-off-by: Tim Gates <tim.gates@iress.com> Co-authored-by: Sergio Wilson <wilsonsergio2500@gmail.com> Co-authored-by: Sergio Wilson <sergio.wilson@foxpoint.com> Co-authored-by: Alex Hoyau <a.hoyau@silexlabs.org> Co-authored-by: Zach Sadler <zaxcoding@gmail.com> Co-authored-by: Esteban Gonzalez <32603471+estebgonza@users.noreply.github.com> Co-authored-by: Alex Ritter <alex@undo.app> Co-authored-by: jacobisknight <jacob@sotechworks.com> Co-authored-by: Tim Gates <tim.gates@iress.com> Co-authored-by: Himansh <77732259+himansh-gjr@users.noreply.github.com> Co-authored-by: Singwai Chan <c.singwai@gmail.com> Co-authored-by: Paul Rill <paulrill2000@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I noticed that the typing for
editor.triggerdid not match betweeneditor/index.tsand the rootindex.d.ts, so I updated theindex.d.tsto include theargsparam.