Refactor Traits Collection #4983
Merged
+125
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artf
reviewed
Mar 23, 2023
artf
requested changes
Mar 26, 2023
|
|
||
| return Collection.prototype.add.apply(this, [models as Trait[], opt]); | ||
| return super.add(trait, opt); |
There was a problem hiding this comment.
I'm not sure exactly what is happening here but with these changes to Traits, undo/redo on traits doesn't work properly (eg. I tried my latest fix here and it works only if I rollback these changes)
There was a problem hiding this comment.
I added a test to cover the undo scenario and fixed it :) Sorry I couldn't have time earlier :(
artf
approved these changes
Jun 15, 2023
|
Awesome, thanks @xQwexx ❤️ |
artf
added a commit
that referenced
this pull request
Jul 4, 2023
* Add autoFormat option to CodeMirrorEditor * Add optsCodeViewer * Remove unused options * Use createViewer in ExportTemplate * Up ExportTemplate * Cleanup * Up panel/index to TS * Refactor Panels TS #5144 * Cleanup * Up panels test * Fix `usePlugin is not a function`. Closes #5167 * Move css_composer/index to TS * Up css_composer tests * Up tests * Add `addStyles` option to `editor.Css.setRule`. Closes #5173 * Update setRule JSDoc * Fix PropertyStack in bundled dts file. Closes #5154 * Fixed broken link in README.md (#5188) Update README.md added ".com" in a not functioning link. * Refactor Traits Collection (#4983) * Refactor Traits Collection * Fix css prefix * Fix trait undo and add test for it --------- Co-authored-by: Artur Arseniev <artur.catch@hotmail.it> * Update keymaps add jsdoc * Improve typings (#5192) * add component:resize to ComponentEvent type * limit storageManager type to be 'local' | 'remote' | undefined * add type to components parameter * Use LiteralUnion in storage_manager config * Up editor TS * Improve components TS * Update ComponentModelDefinition * [Docs] Update Broken Links for (Component Types, and Commands) (#5196) update links * Don't remove styles with avoidInlineStyle #4503 * Up block_manager * Up device_manager * Up pages TS * Add PageProperties * Update PageManager TS * Export Sector/s in TS * Up style_manager TS * Up Property TS * Up TS * Up TS * Up canvas class * Fix SwitchVisibility * Store custom selector manager container * Refactor OpenStyleManager * Up OpenStyleManager * Up OpenStyleManager * Up selector_manager * Add custom option to trait_manager * Up trait model * Up OpenTraitManager for custom traits * Up * Handle properly Component model `defaults` as functions. Closes #5199 * Fix PropertyFactory tests * Up RTE doc * Update rich_text_editor.md (#5201) The previous code snippet encountered a syntax error when attempting to use it in my application. To ensure its usability for others, I have made necessary updates to resolve the syntax error and enable successful execution. These modifications aim to provide a code snippet that can be easily utilized by anyone without encountering any syntax-related issues. * Build * Up docs --------- Co-authored-by: pfaffmann <48207288+pfaffmann@users.noreply.github.com> Co-authored-by: Alex Ritter <ritt.alex@gmail.com> Co-authored-by: Julia Alberici <julia.jpa0@gmail.com> Co-authored-by: Abdelrhman Said <70618755+AbdelrhmanSaid@users.noreply.github.com> Co-authored-by: Ai Anshu <68537640+gxanshu@users.noreply.github.com>
pety-dc
pushed a commit
to d-code-ltd/grapesjs
that referenced
this pull request
Aug 14, 2023
* Refactor Traits Collection * Fix css prefix * Fix trait undo and add test for it --------- Co-authored-by: Artur Arseniev <artur.catch@hotmail.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to work on making the traits better, but first I wanted to tidy the current code.