Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update Broken Links for (Component Types, and Commands) #5196

Merged
merged 1 commit into from Jun 21, 2023
Merged

[Docs] Update Broken Links for (Component Types, and Commands) #5196

merged 1 commit into from Jun 21, 2023

Conversation

AbdelrhmanSaid
Copy link
Contributor

Hey there,
I hope this message finds you well. I'm reaching out to submit a pull request that addresses an issue we've encountered with broken links in our codebase.

In our current state, several JavaScript (.js) links throughout the project docs are resulting in 404 errors. To resolve this issue, I have made the necessary updates to replace these broken .js links with TypeScript (.ts) equivalents.

Please review the changes at your earliest convenience. Your feedback and suggestions for improvement are highly appreciated. If any adjustments or additional tests are required, please let me know, and I will address them promptly.

Thank you for your attention to this matter. I look forward to your review and merging these changes to the main branch.

Best regards,
Abdelrhman Said

@artf artf merged commit ca03f2c into GrapesJS:dev Jun 21, 2023
2 checks passed
@artf
Copy link
Member

artf commented Jun 21, 2023

Thanks @AbdelrhmanSaid

@AbdelrhmanSaid AbdelrhmanSaid deleted the update-docs-links branch June 21, 2023 07:36
artf added a commit that referenced this pull request Jul 4, 2023
* Add autoFormat option to CodeMirrorEditor

* Add optsCodeViewer

* Remove unused options

* Use createViewer in ExportTemplate

* Up ExportTemplate

* Cleanup

* Up panel/index to TS

* Refactor Panels TS #5144

* Cleanup

* Up panels test

* Fix `usePlugin is not a function`. Closes #5167

* Move css_composer/index to TS

* Up css_composer tests

* Up tests

* Add `addStyles` option to `editor.Css.setRule`. Closes #5173

* Update setRule JSDoc

* Fix PropertyStack in bundled dts file. Closes #5154

* Fixed broken link in README.md (#5188)

Update README.md

added ".com" in a not functioning link.

* Refactor Traits Collection (#4983)

* Refactor Traits Collection

* Fix css prefix

* Fix trait undo and add test for it

---------

Co-authored-by: Artur Arseniev <artur.catch@hotmail.it>

* Update keymaps add jsdoc

* Improve typings (#5192)

* add component:resize to ComponentEvent type

* limit storageManager type to be 'local' | 'remote' | undefined

* add type to components parameter

* Use LiteralUnion in storage_manager config

* Up editor TS

* Improve components TS

* Update ComponentModelDefinition

* [Docs] Update Broken Links for (Component Types, and Commands) (#5196)

update links

* Don't remove styles with avoidInlineStyle #4503

* Up block_manager

* Up device_manager

* Up pages TS

* Add PageProperties

* Update PageManager TS

* Export Sector/s in TS

* Up style_manager TS

* Up Property TS

* Up TS

* Up TS

* Up canvas class

* Fix SwitchVisibility

* Store custom selector manager container

* Refactor OpenStyleManager

* Up OpenStyleManager

* Up OpenStyleManager

* Up selector_manager

* Add custom option to trait_manager

* Up trait model

* Up OpenTraitManager for custom traits

* Up

* Handle properly Component model `defaults` as functions. Closes #5199

* Fix PropertyFactory tests

* Up RTE doc

* Update rich_text_editor.md (#5201)

The previous code snippet encountered a syntax error when attempting to use it in my application. To ensure its usability for others, I have made necessary updates to resolve the syntax error and enable successful execution. These modifications aim to provide a code snippet that can be easily utilized by anyone without encountering any syntax-related issues.

* Build

* Up docs

---------

Co-authored-by: pfaffmann <48207288+pfaffmann@users.noreply.github.com>
Co-authored-by: Alex Ritter <ritt.alex@gmail.com>
Co-authored-by: Julia Alberici <julia.jpa0@gmail.com>
Co-authored-by: Abdelrhman Said <70618755+AbdelrhmanSaid@users.noreply.github.com>
Co-authored-by: Ai Anshu <68537640+gxanshu@users.noreply.github.com>
pety-dc pushed a commit to d-code-ltd/grapesjs that referenced this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants