Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test VANILLA builds in CI #164

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Conversation

jamesETsmith
Copy link

General

This PR resolves #156 and adds builds using LAGRAPH_VANILLA=1 (i.e. turning on vanilla builds) to the CI.

Details

The vanilla builds aren't tested with several versions of GraphBLAS like non-vanilla builds, they use the latest one (currently 7.4.1). If you'd like me to add more configurations for vanilla builds, I can, just let me know!

Copy link
Contributor

@szarnyasg szarnyasg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The CI failures are caused by a lack of rights to publish and will go away once the PR is merged.

@jamesETsmith
Copy link
Author

I just realized that my feature branch is based off of dev and not stable. I can close this PR and open a new one to the dev branch. Apologies for not catching that earlier. @szarnyasg is that ok?

@szarnyasg szarnyasg changed the base branch from stable to dev March 6, 2023 21:50
@szarnyasg
Copy link
Contributor

@jamesETsmith it's possible to change the base branch – just did that.

@jamesETsmith
Copy link
Author

@szarnyasg, wasn't aware of that feature, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI should perform VANILLA builds and run its tests to make sure it continues to build properly.
2 participants