Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connections - Adds tests and documentation #108

Merged

Conversation

NeedleInAJayStack
Copy link
Member

This adds tests and documentation to the Connection system, which should improve stability, maintainability, and adoption of this feature.

@cshadek
Copy link
Contributor

cshadek commented Mar 13, 2023

Should there be a test for when a connection is a field on a Type, or is that not needed?

@NeedleInAJayStack
Copy link
Member Author

@cshadek Yeah, I originally had them as object fields, but it made these tests pretty verbose. I've added one here
#109 where I fix the Connection aliasing issue you reported.

Copy link
Member

@d-exclaimation d-exclaimation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants