Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes connection processing order #109

Merged

Conversation

NeedleInAJayStack
Copy link
Member

@NeedleInAJayStack NeedleInAJayStack commented Mar 12, 2023

Fixes issue #106

This orders Connection in front of Type, which avoids errors when types have a field that results in a Connection object

This orders Connection in front of Type, which avoids errors when types have a field with a Connection object
@NeedleInAJayStack
Copy link
Member Author

@cshadek, do you mind giving this a look and verifying that it solves #106 for you?

@cshadek
Copy link
Contributor

cshadek commented Mar 13, 2023

@NeedleInAJayStack, I just tested it and it fixes #106. Nice work!

Copy link
Member

@d-exclaimation d-exclaimation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfectly fine to me

@paulofaria
Copy link
Member

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants